Closed
Conversation
5f0d8dd to
c03f022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsc+ manual copy withvp pack(tsdown). Output is a single CJS bundle atdist/index.js(~24 KB) with generated.d.tstypes. Removesapp.plugin.jsshim.bun:testto Vitest (vite-plus/test). Co-locate test files next to source modules instead of a separate__tests__/directory.vp checkwith type-aware linting (oxlint + tsgolint) andvp fmt(oxfmt). Fix all lint errors acrosssrc/andexamples/.@types/bun,prettier,expo-module-scripts,concurrently,typescriptfrom devDeps. Add@types/node,@types/react,vite-plus,@vitest/coverage-v8. Move@expo/config-pluginstopeerDependencies.serviceExtensionFiles/fromsrc/support/to package root (static assets don't belong in the build pipeline). Add roottsconfig.json. ExportOneSignalPluginPropstype from package entry.index.jsentry point to fix Metro resolution under bun's nestednode_moduleslayout.Test plan
vp test— 49 tests passvp check src examples— no errors or warningsvp pack— buildsdist/index.js+dist/index.d.tsbun run iosfromexamples/demo— verify app loads and plugin appliesbun run androidfromexamples/demo— verify app loads and plugin appliesbun run iosfromexamples/disable-nse— verify NSE is not addedMade with Cursor