Skip to content

chore: format codebase with vite-plus formatter#292

Merged
fadi-george merged 4 commits intomainfrom
fadi/vp-format
Mar 21, 2026
Merged

chore: format codebase with vite-plus formatter#292
fadi-george merged 4 commits intomainfrom
fadi/vp-format

Conversation

@fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Mar 20, 2026

Description

One Line Summary

Format the codebase with the Vite+ formatter (vp fmt) so src, examples, and config share one consistent style on the SDK-4199 Vite+ branch.

Details

Motivation

The fadi/sdk-4199-add-vite-to-expo-sdk work introduces Vite+ as the unified toolchain. Running the Vite+ formatter establishes a single baseline for quotes, import order, and spacing, which keeps reviews focused on real changes and matches the tooling the repo now uses.

Scope

  • Intended: Formatting-only edits across src/, examples/, and related files touched by the formatter.
  • Not intended: No behavior changes, no plugin API changes, and no functional changes to native projects beyond what a pure format pass implies.

Testing

Manual testing

  • Ran vp fmt to apply the formatter across the codebase.
  • Ran vp check — formatting, lint, and TypeScript all pass (80 source files checked in this run).
  • Skipped physical device / Android & iOS app runs: this PR is style-only and does not change runtime behavior; native verification is unchanged from the base branch.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible
  • I have tested this on the latest version of the plugin
  • I have tested this on both Android and iOS, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@fadi-george fadi-george requested a review from a team as a code owner March 20, 2026 23:51
Base automatically changed from fadi/sdk-4199-add-vite-to-expo-sdk to main March 21, 2026 00:03
The module is imported directly in source but was only available as a
transitive dependency of the @expo/config-plugins peer, which pnpm's
strict hoisting in CI does not resolve.

Made-with: Cursor
@fadi-george fadi-george merged commit 7610bf3 into main Mar 21, 2026
2 of 3 checks passed
@fadi-george fadi-george deleted the fadi/vp-format branch March 21, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants