Skip to content

Account For Random Starting Items When Building Misc Hints #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdunn596 wants to merge 3 commits into
base: Dev
Choose a base branch
from
Open

Account For Random Starting Items When Building Misc Hints #2503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84d46e0
account for random starting items when building misc hints
jdunn596 Dec 27, 2025
3bed82f
use paren syntax instead of \
jdunn596 Dec 27, 2025
f9682d8
make seperation of conditions more explicit
jdunn596 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,7 +1818,10 @@ def build_misc_item_hints(world: World, messages: list[Message], allow_duplicate
for hint_type, data in misc_item_hint_table.items():
if hint_type in world.settings.misc_hints:
item = world.misc_hint_items[hint_type]
if item in world.distribution.effective_starting_items and world.distribution.effective_starting_items[item].count > 0:
if (
(item in world.distribution.effective_starting_items and world.distribution.effective_starting_items[item].count > 0) or
(item in world.distribution.randomized_starting_items and world.distribution.randomized_starting_items[item] > 0)
):
if item == data['default_item']:
text = data['default_item_text'].format(area='#your pocket#')
else:
Expand Down