Fix error messages for metadata found during attach#860
Closed
Deixx wants to merge 1 commit intoOpen-CAS:masterfrom
Closed
Fix error messages for metadata found during attach#860Deixx wants to merge 1 commit intoOpen-CAS:masterfrom
Deixx wants to merge 1 commit intoOpen-CAS:masterfrom
Conversation
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Deixx
force-pushed
the
attach-error-msg
branch
from
f7e7fb5 to
db413d2
Compare
robertbaldyga
requested changes
Jan 24, 2025
inc/ocf_mngt.h
Outdated
| * Used for proper error handling to differentiate between start-cache | ||
| * and attach-cache operations, and display proper error message. | ||
| */ | ||
| bool is_cmd_attach; |
Member
There was a problem hiding this comment.
This is an implementation detail and should not be exposed to the adapter.
Contributor
Author
There was a problem hiding this comment.
Sure, I've changed it to utilise cache_state
Contributor
Author
There was a problem hiding this comment.
I've moved the differentiation to OCL, but this small change is still required
Deixx
force-pushed
the
attach-error-msg
branch
from
db413d2 to
c03cda1
Compare
Deixx
force-pushed
the
attach-error-msg
branch
from
c03cda1 to
de05e85
Compare
Contributor
Author
|
Metadata will be zeroed on detach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.