Conversation
m-mohr
requested review from
clausmichele,
dthiex,
jdries,
mkadunc,
rtmiz and
soxofaan
mkadunc
requested changes
Jul 17, 2025
Member
mkadunc
left a comment
mkadunc
left a comment
There was a problem hiding this comment.
- bugs in description for the case when nodata is ignored.
- description prescribed traversal order in implementation; I suggest rephrasing to allow implementation to evaluate elements in any order
- suggestion to make the last sentence more clear (use of "unambiguous when" instead of "ambiguous unless")
Member
Author
|
Thanks and sorry, @mkadunc. I should have checked the PR more closely, created 10 or so in a row and got a little less cautios with the last ones, it seems. Anyway, all your proposals make sense to me and I merged them. I hope that helps to make the confused emoji above smile in the future ;-) |
soxofaan
approved these changes
Jul 22, 2025
Member
Author
soxofaan
approved these changes
Sep 11, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Next processes release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #494 - See this issue for context.
Please debate whether we want to merge this or not. Just created this for the sake of getting a discussion going ;-)
ChatGPT approves this PR. 🙈