is_nan: Return false instead of true for non-numerical data types
#551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
changed the title
is_nan: Return false instead of true for non-numerical data typ…is_nan: Return false instead of true for non-numerical data types
soxofaan
reviewed
Jul 22, 2025
Co-authored-by: Stefaan Lippens <[email protected]>
soxofaan
approved these changes
Aug 7, 2025
Member
Author
|
Thanks, anyone else has opinions? |
ValentinaHutter
approved these changes
Aug 8, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Next processes release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486 - See this issue for context.
Please debate whether we want to merge this or not. Just created this for the sake of getting a discussion going ;-)