fix:tests #2932
Merged
fix:tests #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernu76
force-pushed
the
fix_tests
branch
2 times, most recently
from
6b89e7f to
d980a04
Compare
ReimarBauer
reviewed
Dec 3, 2025
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
This fix should go to stable
| text = f.read().decode("utf-8") | ||
| expected_version = __version__ | ||
| pattern = rf'value="is:closed milestone:{re.escape(expected_version)} "' | ||
| pattern = rf'value="is:closed milestone:{re.escape(expected_version)}"' |
Member
There was a problem hiding this comment.
this is also wrong in stable. Because github got an update. This test finds updates on github.
please send this to stable
the import needs to become added by the merge from stable to develop
Closed
annapurna-gupta
pushed a commit
to annapurna-gupta/MSS
that referenced
this pull request
Jan 2, 2026
--------- Co-authored-by: ReimarBauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes two failing tests, one bug in test, one bug in documentation generation.
Does this PR introduce a breaking change?
no
Checklist:
<type>: <subject>