Skip to content

fix:tests #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReimarBauer merged 2 commits into from
Dec 3, 2025
Merged

fix:tests #2932

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db32686
Fix two minor issues in test cases.
joernu76 Dec 3, 2025
e384c4b
Update conf.py
ReimarBauer Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/_test_msui/test_msui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def test_milestone_url(self):
with urlopen(self.window.milestone_url) as f:
text = f.read().decode("utf-8")
expected_version = __version__
pattern = rf'value="is:closed milestone:{re.escape(expected_version)} "'
pattern = rf'value="is:closed milestone:{re.escape(expected_version)}"'
Copy link
Member

@ReimarBauer ReimarBauer Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also wrong in stable. Because github got an update. This test finds updates on github.

please send this to stable

assert re.search(pattern, text), f"Expected milestone format not found: {expected_version}"


Expand Down
Loading