-
Notifications
You must be signed in to change notification settings - Fork 3
Radio (LoRa) Integration #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this is for a patch for the gds accepting da packages
I think I accidentally broke the build here by changing the submodules when I was trying to appease the linter. Working on a fix... |
This is strange, it looks like for some reason just running the linter is blowing up the build. I'm going to try re-runing the action on the working commit. Here is the old run for safe keeping: https://github.com/Open-Source-Space-Foundation/proves-core-reference/actions/runs/18269024675/job/52008249263 |
…-core-reference into radio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Runs locally and on integrations. Maybe up the ComQueue a bit so it doesn't keep overflowing, but everything looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to temporarily block merging this into main until we make modifications to our integration test setup at the lab to make it "safe" to allow the radio to transmit unattended.
Currently my understanding is this PR makes all future deployments of the core reference automagically start streaming data out over the radio in the form of the Beacon. The pysquared
radio manager allows us to block transmissions through the config: license
check.
if self._radio_config.license == "":
self._log.warning("Radio send attempt failed: Not licensed.")
return False
Not having this functionality has two potential issues:
- It may unintentionally run afoul of FCC radio frequency regulations by spewing out transmissions in an manner that is not consistent with the developer's licensing privileges
- Transmitting without having an antenna, attenuator, or dummy load attached will cause damage to the radio modules being used for testing.
I'll type out some ideas about what we can do about these things in #59. Off the dome though, shortlist of tasks we'll want to prioritize to get this into main:
- Update the
deathstar
integration test setup to pipe the radio output into an attenuated receiver pair. - Ensure all developers have proper antenna / load setups so we don't accidentally start breaking radios
- Add a
silence
functionality either through another flow control component or a port on the LoRa driver that will place the radio into areceive only
mode until requested to leave it. This doesn't have to happen in this PR, since it was out of the scope of the original SDD, but should happen as soon as possible
…tion test on lav sorry nate!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live from New York City! LGTM! 🎉
Description
This adds the LoRa radio into the topology. Additionally, it adds ComDelay and ComAggregator (fprime version bump) to ensure the radio can send/receive.
Related Issues/Tickets
Close #37.
Resolves #48.
How Has This Been Tested?
Ran radio pair. UTs.
Checklist
Further Notes / Considerations