#2614 do not create logical container neighborhoods

[benjaperez1983]

Fixes #2614

Description

Prevent neighborhoods with logicalcontainers to be created

Type of change

Please mark relevant options with an x in the brackets.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires documentation changes (link at least one user or developer documentation issue):
• Algorithm update - updates algorithm documentation/questions/answers etc.
• Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Integration tests
• Unit tests
• Manual tests
• No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

• Check if the code is well documented
• Check if the behavior is what is expected
• Check if the code is well tested
• Check if the code is readable and well formatted
• Additional checks (document below if any)
• Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

[Yuri05]

s. review comments

[rwmcintosh]

The build has failed from this test should_identify_an_issue_with_initial_condition_being_defined_for_logical_containers

[rwmcintosh]

Also When_validating_a_model_for_which_all_neighborhoods_can_be_resolved and When_validating_a_model_for_which_some_neighborhoods_cannot_be_resolved

[rwmcintosh]

Needs test fixes

[benjaperez1983]

The test if failing due to this error:

"Organism|ArterialBlood|Plasma" -> is being set to Logical before the test, therefore, there is a further validation that ends up on this exception:

I believe for this particular test we should be excluding this formula:
simulationBuilder.SpatialStructureAndMergeBehaviors.FirstOrDefault().spatialStructure.FormulaCache.Clear();
var containerWithFormula = physicalContainer.Children.FirstOrDefault(x => x.Name == "RefParam") as Parameter;
physicalContainer.RemoveChild(containerWithFormula);

This way the validation will not fail for this test, and still the Validation Messages will be added to the List.

[msevestre]

implementation looks perfect to me. One question regarding the tests