Skip to content

Conversation

sir4ur0n
Copy link
Contributor

@sir4ur0n sir4ur0n commented Aug 1, 2025

Fixes #21307
Fixes #21312
Fixes a few more problems I uncovered in the process:

  • Fix support for free-forms (e.g., additionalProperties: true)
  • Fix support for byte arrays
  • Support decimal type
  • Test the whole fake-petstore test suite for OCaml

💡 I tried to split into more atomic commits. These are not perfect, but should help review formatting (e.g., mustache indentation) changes vs actual fixes

💡 This MR/branch is built on top of #21679, so I suggest reviewing/merging #21679 first.

On top of the 2 test suites in this PR, I also manually tested this branch against the OpenAPI spec for which we generate OCaml code at my company, and it works.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cgensoul

@sir4ur0n sir4ur0n force-pushed the fix/ocaml-free-form branch from 0f70f91 to a9e6ca2 Compare August 18, 2025 12:05
@sir4ur0n
Copy link
Contributor Author

Closing this MR as #21798 which contained all the commits was merged.

@sir4ur0n sir4ur0n closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants