-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[OCaml] Introduce support for oneOf
/anyOf
, fix default value for non-required maps
#21798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The implementation may not be correct, but at least it compiles. To be checked if someday someone actually uses it/complains.
let uri = Request.build_uri "/pet/{petId}" in | ||
let headers = Request.default_headers in | ||
let headers = Request.maybe_add_header headers "api_key" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll get this merged first and later maybe come up with a PR to remove these blank lines
curious are you using any linter to format the auto-generated code as part of your development workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about the blank lines in the Mustache files, or in the generated OCaml files?
I think the Mustache files being easy to read is quite important for maintainability 😅
On the other hand, the generated OCaml files being ugly is - in my opinion - not such a big deal because I think almost all projects use a formatter (most often ocamlformat).
I would be happy (probably in another MR) to add an .ocamlformat
file + automatically format OCaml files (either directly from openapi-generator
but it means it becomes a dependency, or only for the generated files versioned in this Git repo, you tell me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about the blank lines in the Mustache files, or in the generated OCaml files?
Generated OCaml files
I think the Mustache files being easy to read is quite important for maintainability 😅
Totally agreed.
On the other hand, the generated OCaml files being ugly is - in my opinion - not such a big deal because I think almost all projects use a formatter (most often ocamlformat).
Nice
I would be happy (probably in another MR) to add an .ocamlformat file
Yes, nice to include one
💡 Review commit by commit for easier review
oneOf
/anyOf
oneOf
feature on some big openapi.json) where non-required maps are missing a@default
in modelsPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)