Skip to content

Conversation

@alec-petersen
Copy link
Contributor

@alec-petersen alec-petersen commented Jan 4, 2026

Fixes #22601

This PR:

  • Makes GetAsync in TokenProvider protected internal so that users can override it when they create their own TokenProvider.
  • Removes the ArgumentException to allow for TokenProviders that generate tokens at runtime instead of having them ready at the beginning of execution.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@alec-petersen
Copy link
Contributor Author

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

@wing328 wing328 added this to the 7.19.0 milestone Jan 12, 2026
@wing328 wing328 merged commit 17f2e46 into OpenAPITools:master Jan 12, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ][CSHARP] Make TokenProvider abstract method GetAsync protected for override

2 participants