Skip to content

[REQ][CSHARP] Make TokenProvider abstract method GetAsync protected for override #22615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 3 commits into from
Jan 12, 2026
Merged

[REQ][CSHARP] Make TokenProvider abstract method GetAsync protected for override #22615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddce46f
Make GetAsync protected internal so external inheritors can override it
alec-petersen Jan 4, 2026
e063a3b
Remove non-zero token length requirement to allow more flexibility fo…
alec-petersen Jan 4, 2026
13de94a
Update samples
alec-petersen Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...pi-generator/src/main/resources/csharp/libraries/generichost/RateLimitProvider`1.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ namespace {{packageName}}.{{clientPackage}}
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default{{^netstandard20OrLater}}(global::System.Threading.CancellationToken){{/netstandard20OrLater}})
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default{{^netstandard20OrLater}}(global::System.Threading.CancellationToken){{/netstandard20OrLater}})
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>{{nrt?}} tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...penapi-generator/src/main/resources/csharp/libraries/generichost/TokenProvider`1.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ namespace {{packageName}}
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default{{^netstandard20OrLater}}(global::System.Threading.CancellationToken){{/netstandard20OrLater}});
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default{{^netstandard20OrLater}}(global::System.Threading.CancellationToken){{/netstandard20OrLater}});

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -31,9 +36,6 @@ namespace {{packageName}}
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...csharp/generichost/latest/ComposedEnum/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...ore/csharp/generichost/latest/ComposedEnum/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...e/csharp/generichost/latest/HelloWorld/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...store/csharp/generichost/latest/HelloWorld/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...arp/generichost/latest/InlineEnumAnyOf/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions .../csharp/generichost/latest/InlineEnumAnyOf/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...re/csharp/generichost/latest/OneOfList/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...tstore/csharp/generichost/latest/OneOfList/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...etstore/csharp/generichost/latest/Tags/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...nt/petstore/csharp/generichost/latest/Tags/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -37,9 +42,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...etstore/csharp/generichost/net10/AllOf/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...nt/petstore/csharp/generichost/net10/AllOf/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...etstore/csharp/generichost/net10/AnyOf/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...nt/petstore/csharp/generichost/net10/AnyOf/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...sharp/generichost/net10/AnyOfNoCompare/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...re/csharp/generichost/net10/AnyOfNoCompare/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -36,9 +41,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...re/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase> tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
10 changes: 6 additions & 4 deletions ...tstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Client/TokenProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
/// </summary>
protected TTokenBase[] _tokens;

internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);
/// <summary>
/// Gets an authentication token to be used in request authorization.
/// </summary>
/// <param name="header"></param>
/// <param name="cancellation"></param>
protected internal abstract System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default);

/// <summary>
/// Instantiates a TokenProvider.
Expand All @@ -34,9 +39,6 @@ public abstract class TokenProvider<TTokenBase> where TTokenBase : TokenBase
public TokenProvider(IEnumerable<TTokenBase> tokens)
{
_tokens = tokens.ToArray();

if (_tokens.Length == 0)
throw new ArgumentException("You did not provide any tokens.");
}
}
}
3 changes: 2 additions & 1 deletion ...p/generichost/net10/NullReferenceTypes/src/Org.OpenAPITools/Client/RateLimitProvider`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public RateLimitProvider(TokenContainer<TTokenBase> container) : base(container.
}
}

internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
/// <inheritdoc/>
protected internal override async System.Threading.Tasks.ValueTask<TTokenBase> GetAsync(string header = "", System.Threading.CancellationToken cancellation = default)
{
if (!AvailableTokens.TryGetValue(header, out global::System.Threading.Channels.Channel<TTokenBase>? tokens))
throw new KeyNotFoundException($"Could not locate a token for header '{header}'.");
Expand Down
Loading
Loading