Skip to content

Conversation

@mariot
Copy link
Member

@mariot mariot commented Dec 31, 2025

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@mariot mariot self-assigned this Dec 31, 2025
@mariot mariot added feature use for describing a new feature to develop connector: qradar labels Dec 31, 2025
@romain-filigran romain-filigran added the filigran team use to identify PR from the Filigran team label Jan 4, 2026
Powlinett
Powlinett previously approved these changes Jan 5, 2026
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connector behaves as expected 👍

"""
In case of stream_id configuration is missing, raise ValueError
"""
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass should be removed

@mariot mariot requested a review from Powlinett January 5, 2026 16:10
@mariot mariot merged commit b188ec8 into master Jan 5, 2026
6 checks passed
@mariot mariot deleted the feat/5495-remove-live branch January 5, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connector: qradar feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qradar] remove 'live' as default value for livestream id

4 participants