Skip to content

[qradar] remove live as default value #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariot merged 3 commits into from
Jan 5, 2026
Merged

[qradar] remove live as default value #5496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e3b6a2
[qradar] remove live as default value
mariot Dec 31, 2025
6839d3a
Add validation for stream_id configuration
mariot Jan 5, 2026
9d374eb
Merge branch 'master' into feat/5495-remove-live
mariot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stream/qradar/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
- OPENCTI_URL=http://localhost
- OPENCTI_TOKEN=ChangeMe
- CONNECTOR_ID=ChangeMe
- CONNECTOR_LIVE_STREAM_ID=live # ID of the live stream created in the OpenCTI UI
- CONNECTOR_LIVE_STREAM_ID=changeme # ID of the live stream created in the OpenCTI UI
- CONNECTOR_LIVE_STREAM_LISTEN_DELETE=true
- CONNECTOR_LIVE_STREAM_NO_DEPENDENCIES=true
- CONNECTOR_NAME=OpenCTI QRADAR Connector
Expand Down
2 changes: 1 addition & 1 deletion stream/qradar/src/config.yml.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ opencti:
connector:
id: 'ChangeMe'
type: 'STREAM'
live_stream_id: 'live' # ID of the live stream created in the OpenCTI UI
live_stream_id: 'changeme' # ID of the live stream created in the OpenCTI UI
live_stream_listen_delete: true
live_stream_no_dependencies: true
name: 'QRadar'
Expand Down
12 changes: 12 additions & 0 deletions stream/qradar/src/qradar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ def __init__(self):
)
sys.exit(0)

def check_stream_id(self):
"""
In case of stream_id configuration is missing, raise ValueError
"""
pass
Copy link
Member

@Powlinett Powlinett Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass should be removed

if (
not self.helper.connect_live_stream_id
or self.helper.connect_live_stream_id.lower() == "changeme"
):
raise ValueError("Missing stream ID, please check your configurations.")

def _initialize_reference_sets(self):
"""
:return:
Expand Down Expand Up @@ -367,6 +378,7 @@ def _process_message(self, msg):
return None

def start(self):
self.check_stream_id()
self.helper.listen_stream(self._process_message)


Expand Down