Skip to content

Improve diagnostics for ADI_c interface coupling #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-platt merged 4 commits into from
Jan 29, 2025
Merged

Improve diagnostics for ADI_c interface coupling #2615

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
459143f
ADI_C: change case on OutVTKDir for clarity
andrew-platt Jan 22, 2025
507014d
ADI: write meshes before mapping
andrew-platt Jan 24, 2025
a2ce2c3
ADI: add debugging info on blade mapping
andrew-platt Jan 24, 2025
5346b39
ADI: make names for BldStrcMesh vtk outputs consistent
andrew-platt Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 62 additions & 22 deletions modules/aerodyn/src/AeroDyn_Inflow_C_Binding.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ SUBROUTINE ADI_C_Init( ADinputFilePassed, ADinputFileString_C, ADinputFileString
character(ErrMsgLen) :: ErrMsg !< aggregated error message
integer(IntKi) :: ErrStat2 !< temporary error status from a call
character(ErrMsgLen) :: ErrMsg2 !< temporary error message from a call
character(IntfStrLen) :: OutVTKdir !< Output directory for files (relative to current location)
character(IntfStrLen) :: OutVTKDir !< Output directory for files (relative to current location)
integer(IntKi) :: i,j,k !< generic index variables
integer(IntKi) :: iWT !< current turbine number (iterate through during setup for ADI_Init call)
integer(IntKi) :: AeroProjMod !< for checking that all turbines use the same AeroProjMod
Expand Down Expand Up @@ -517,10 +517,10 @@ SUBROUTINE ADI_C_Init( ADinputFilePassed, ADinputFileString_C, ADinputFileString
i = INDEX(OutRootName,C_NULL_CHAR) - 1 ! if this has a c null character at the end...
if ( i > 0 ) OutRootName = OutRootName(1:I) ! remove it

! OutVTKdir -- output directory
OutVTKdir = TRANSFER( OutVTKdir_C, OutVTKdir )
i = INDEX(OutVTKdir,C_NULL_CHAR) - 1 ! if this has a c null character at the end...
if ( i > 0 ) OutVTKdir = OutVTKdir(1:I) ! remove it
! OutVTKDir -- output directory
OutVTKDir = TRANSFER( OutVTKDir_C, OutVTKDir )
i = INDEX(OutVTKDir,C_NULL_CHAR) - 1 ! if this has a c null character at the end...
if ( i > 0 ) OutVTKDir = OutVTKDir(1:I) ! remove it

! For debugging the interface:
if (DebugLevel > 0) then
Expand Down Expand Up @@ -669,10 +669,10 @@ SUBROUTINE ADI_C_Init( ADinputFilePassed, ADinputFileString_C, ADinputFileString
call SetupMotionLoadsInterfaceMeshes(); if (Failed()) return
! setup meshes
if (WrOutputsData%WrVTK > 0_IntKi) then
if (len_trim(OutVTKdir) <= 0) then
OutVTKdir = 'vtk-ADI'
if (len_trim(OutVTKDir) <= 0) then
OutVTKDir = 'vtk-ADI'
endif
call setVTKParameters(WrOutputsData, Sim, ADI, ErrStat2, ErrMsg2, OutVTKdir)
call setVTKParameters(WrOutputsData, Sim, ADI, ErrStat2, ErrMsg2, OutVTKDir)
if (Failed()) return
endif
! write meshes for this rotor
Expand All @@ -682,6 +682,8 @@ SUBROUTINE ADI_C_Init( ADinputFilePassed, ADinputFileString_C, ADinputFileString
enddo
if (Failed()) return
endif
! Map the meshes (doing this after writing so we can check if it fails)
call MapLoadsInterfaceMeshes(); if (Failed()) return

! Setup points for calculating disk average velocity
do iWT=1,Sim%NumTurbines
Expand Down Expand Up @@ -771,10 +773,12 @@ SUBROUTINE ADI_C_Init( ADinputFilePassed, ADinputFileString_C, ADinputFileString


CONTAINS
logical function Failed()
logical function Failed(Msg)
character(*), optional :: Msg
CALL SetErrStat( ErrStat2, ErrMsg2, ErrStat, ErrMsg, RoutineName )
Failed = ErrStat >= AbortErrLev
if (Failed) then
if (present(Msg)) ErrMsg = trim(ErrMsg)//' ('//trim(Msg)//')'
call ClearTmpStorage()
call SetErr(ErrStat,ErrMsg,ErrStat_C,ErrMsg_C)
endif
Expand Down Expand Up @@ -959,8 +963,8 @@ subroutine SetupMotionLoadsInterfaceMeshes()
do iBlade=1,Sim%WT(iWT)%NumBlades
!-------------------------------------------------------------
! Load mesh for blades
CALL MeshCopy( SrcMesh = BldStrMotionMesh(iWT)%Mesh(iBlade) ,&
DestMesh = BldStrLoadMesh(iWT)%Mesh(iBlade) ,&
CALL MeshCopy( SrcMesh = BldStrMotionMesh(iWT)%Mesh(iBlade) ,&
DestMesh = BldStrLoadMesh(iWT)%Mesh(iBlade) ,&
CtrlCode = MESH_SIBLING ,&
IOS = COMPONENT_OUTPUT ,&
ErrStat = ErrStat2 ,&
Expand All @@ -971,8 +975,8 @@ subroutine SetupMotionLoadsInterfaceMeshes()
BldStrMotionMesh(iWT)%Mesh(iBlade)%RemapFlag = .FALSE.

! Temp mesh for load transfer
CALL MeshCopy( SrcMesh = BldStrLoadMesh(iWT)%Mesh(iBlade) ,&
DestMesh = BldStrLoadMesh_tmp(iWT)%Mesh(iBlade) ,&
CALL MeshCopy( SrcMesh = BldStrLoadMesh(iWT)%Mesh(iBlade) ,&
DestMesh = BldStrLoadMesh_tmp(iWT)%Mesh(iBlade) ,&
CtrlCode = MESH_COUSIN ,&
IOS = COMPONENT_OUTPUT ,&
ErrStat = ErrStat2 ,&
Expand All @@ -985,16 +989,30 @@ subroutine SetupMotionLoadsInterfaceMeshes()
! For checking the mesh
! Note: CU is is output unit (platform dependent).
if (DebugLevel >= 4) call MeshPrintInfo( CU, BldStrLoadMesh(iWT)%Mesh(iBlade), MeshName='BldStrLoadMesh'//trim(Num2LStr(iWT))//'_'//trim(Num2LStr(iBlade)) )
enddo ! iBlade
enddo ! iWT
end subroutine SetupMotionLoadsInterfaceMeshes

!> This subroutine sets the interface meshes to map to the input motions to the AD
!! meshes
subroutine MapLoadsInterfaceMeshes()
integer(IntKi) :: iWT !< current rotor/turbine
integer(IntKi) :: iBlade !< current blade

! Step through all turbine rotors
do iWT=1,Sim%NumTurbines
!-------------------------------------------------------------
! Load mesh for blades
! Step through all blades on this rotor
do iBlade=1,Sim%WT(iWT)%NumBlades
!-------------------------------------------------------------
! Set the mapping meshes
! blades
call MeshMapCreate( BldStrMotionMesh(iWT)%Mesh(iBlade), ADI%u(1)%AD%rotors(iWT)%BladeMotion(iBlade), Map_BldStrMotion_2_AD_Blade(iBlade, iWT), ErrStat2, ErrMsg2 ); if(Failed()) return
call MeshMapCreate( ADI%y%AD%rotors(iWT)%BladeLoad(iBlade), BldStrLoadMesh(iWT)%Mesh(iBlade), Map_AD_BldLoad_P_2_BldStrLoad(iBlade, iWT), ErrStat2, ErrMsg2 ); if(Failed()) return
call MeshMapCreate( BldStrMotionMesh(iWT)%Mesh(iBlade), ADI%u(1)%AD%rotors(iWT)%BladeMotion(iBlade), Map_BldStrMotion_2_AD_Blade(iBlade, iWT), ErrStat2, ErrMsg2 ); if(Failed('Struct to blade '//trim(Num2LStr(iBlade)))) return
call MeshMapCreate( ADI%y%AD%rotors(iWT)%BladeLoad(iBlade), BldStrLoadMesh(iWT)%Mesh(iBlade), Map_AD_BldLoad_P_2_BldStrLoad(iBlade, iWT), ErrStat2, ErrMsg2 ); if(Failed('Blade '//trim(Num2LStr(iBlade))//' to struct')) return
enddo ! iBlade
enddo ! iWT

end subroutine SetupMotionLoadsInterfaceMeshes
end subroutine MapLoadsInterfaceMeshes


!-------------------------------------------------------------
Expand Down Expand Up @@ -1424,7 +1442,7 @@ subroutine ADI_C_SetupRotor(iWT_c, TurbineIsHAWT_c, TurbOrigin_C, &
integer(IntKi) :: ErrStat2 !< temporary error status from a call
character(ErrMsgLen) :: ErrMsg2 !< temporary error message from a call
integer(IntKi) :: i,j,k !< generic index variables
character(*), parameter :: RoutineName = 'ADI_C_Init' !< for error handling
character(*), parameter :: RoutineName = 'ADI_C_SetupRotor' !< for error handling

! Initialize error handling
ErrStat = ErrID_None
Expand Down Expand Up @@ -1493,6 +1511,9 @@ subroutine ADI_C_SetupRotor(iWT_c, TurbineIsHAWT_c, TurbOrigin_C, &
if (Failed()) return
endif

! check Mesh points for blade specification
call CheckMeshPts(iWT); if (Failed()) return

call SetupMotionMesh()

! Set error status
Expand Down Expand Up @@ -1523,8 +1544,9 @@ end function Failed0
!> This subroutine prints out all the variables that are passed in. Use this only
!! for debugging the interface on the Fortran side.
subroutine ShowPassedData()
character(1) :: TmpFlag
integer :: i,j
character(1) :: TmpFlag
integer :: i,j
character(35) :: TmpStr
call WrSCr("")
call WrScr("-----------------------------------------------------------")
call WrScr("Interface debugging: Variables passed in through interface")
Expand Down Expand Up @@ -1566,10 +1588,28 @@ subroutine ShowPassedData()
j=9*(i-1)
call WrMatrix(InitMeshOri_C(j+1:j+9),CU,'(9(ES23.15e2))')
enddo
call WrScr(" Node mapping")
call WrScr(" MeshPt Blade")
do i=1,int(NumMeshPts_C,IntKi)
write(TmpStr,'(15X,I5,10X,I5)') i,int(MeshPtToBladeNum_C(i),IntKi)
call WrScr(TmpStr)
enddo
endif
call WrScr("-----------------------------------------------------------")
end subroutine ShowPassedData

!> very basic checks on mesh points
subroutine CheckMeshPts(iWT)
integer(IntKi), intent(in) :: iWT
do i=1,size(MeshPtToBladeNum_C)
if ((MeshPtToBladeNum_C(i) < 1_c_int) .or. (MeshPtToBladeNum_C(i) > int(Sim%WT(iWT)%NumBlades))) then
ErrStat2=ErrID_Fatal
ErrMsg2 = 'Mesh Point '//trim(Num2LStr(i))//' assigned to invalid blade '//trim(Num2LStr(MeshPtToBladeNum_C(i)))//' on rotor '//trim(Num2LStr(iWT))
if (Failed()) return
endif
enddo
end subroutine CheckMeshPts

subroutine SetupMotionMesh()
real(ReKi) :: InitPos(3)
real(R8Ki) :: Orient(3,3)
Expand Down Expand Up @@ -2302,7 +2342,7 @@ subroutine WrVTK_PointsRef(ErrStat3,ErrMsg3)

! Blade point motion (structural mesh from driver)
do iBlade=1,Sim%WT(iWT)%NumBlades
call MeshWrVTKreference(RefPoint, BldStrMotionMesh(iWT)%Mesh(iBlade), trim(WrOutputsData%VTK_OutFileRoot)//trim(sWT)//'.BldStrMotionMesh', ErrStat3, ErrMsg3)
call MeshWrVTKreference(RefPoint, BldStrMotionMesh(iWT)%Mesh(iBlade), trim(WrOutputsData%VTK_OutFileRoot)//trim(sWT)//'.BldStrMotionMesh'//trim(Num2LStr(iBlade)), ErrStat3, ErrMsg3)
if (ErrStat3 >= AbortErrLev) return
enddo

Expand Down Expand Up @@ -2409,7 +2449,7 @@ subroutine WrVTK_Points(ErrStat3,ErrMsg3)

! Blade point motion (structural mesh from driver)
do iBlade=1,Sim%WT(iWT)%NumBlades
call MeshWrVTK(RefPoint, BldStrMotionMesh(iWT)%Mesh(iBlade), trim(WrOutputsData%VTK_OutFileRoot)//trim(sWT)//'.BldStrMotionMesh'//trim(num2lstr(iBlade)), n_VTK, .true., ErrStat3, ErrMsg3, WrOutputsData%VTK_tWidth)
call MeshWrVTK(RefPoint, BldStrMotionMesh(iWT)%Mesh(iBlade), trim(WrOutputsData%VTK_OutFileRoot)//trim(sWT)//'.BldStrMotionMesh'//trim(Num2LStr(iBlade)), n_VTK, .true., ErrStat3, ErrMsg3, WrOutputsData%VTK_tWidth)
if (ErrStat3 >= AbortErrLev) return
enddo

Expand Down