Change eval_limit from choice to free-form string input#2261
Merged
Conversation
The choice dropdown only allowed specific values (1, 50, 100, 200, 500), making it annoying to debug with custom instance counts (e.g., 10). Change to a string input so any positive integer can be entered. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
API breakage checks (Griffe)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solves a real problem (debugging with arbitrary limits) by removing unnecessary constraints. However, needs input validation to prevent confusing failures.
Validate that eval_limit is a positive integer to fail fast with a clear error instead of causing confusing failures downstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
all-hands-bot
approved these changes
Mar 2, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Simple, pragmatic solution.
Removes unnecessary dropdown constraints while adding proper validation. The regex ^[1-9][0-9]*$ correctly rejects zero, negatives, decimals, and non-numeric strings. Solves a real debugging problem (running arbitrary instance counts) without over-engineering. LGTM! ✅
neubig
approved these changes
Mar 2, 2026
4 tasks
zparnold
added a commit
to zparnold/software-agent-sdk
that referenced
this pull request
Mar 5, 2026
Cherry-pick from upstream e96bce3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval_limitworkflow input fromtype: choice(restricted to 1/50/100/200/500) totype: string(any positive integer).agents/skills/run-eval.mdto reflect the changeMotivation
The choice dropdown is limiting when debugging — e.g., wanting to run exactly 10 instances requires picking from a fixed list. A free-form string input lets you type any number.
Test plan
run-eval.ymlvia workflow dispatch with a non-standard value (e.g.,10) and verify it works🤖 Generated with Claude Code
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:7385f4d-pythonRun
All tags pushed for this build
About Multi-Architecture Support
7385f4d-python) is a multi-arch manifest supporting both amd64 and arm647385f4d-python-amd64) are also available if needed