Skip to content

Change eval_limit from choice to free-form string input #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neubig merged 2 commits into from
Mar 2, 2026
Merged

Change eval_limit from choice to free-form string input #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9309b05
Change eval_limit from choice to free-form string input
simonrosenberg Mar 2, 2026
60fad3f
Add validation for eval_limit input
simonrosenberg Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/run-eval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ curl -X POST \

**Key parameters:**
- `benchmark`: `swebench`, `swebenchmultimodal`, `gaia`, `swtbench`, `commit0`, `multiswebench`
- `eval_limit`: `1`, `50`, `100`, `200`, `500`
- `eval_limit`: Any positive integer (e.g., `1`, `10`, `50`, `200`)
- `model_ids`: See `.github/run-eval/resolve_model_config.py` for available models
- `benchmarks_branch`: Use feature branch from the benchmarks repo to test benchmark changes before merging

Expand Down
18 changes: 10 additions & 8 deletions .github/workflows/run-eval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,10 @@ on:
default: false
type: boolean
eval_limit:
description: Number of instances to run
description: Number of instances to run (any positive integer)
required: false
default: '1'
type: choice
options:
- '1'
- '100'
- '50'
- '200'
- '500'
type: string
model_ids:
description: Comma-separated model IDs to evaluate. Must be keys of MODELS in resolve_model_config.py. Defaults to first model in that
dict.
Expand Down Expand Up @@ -138,6 +132,14 @@ jobs:
with:
python-version: '3.13'

- name: Validate eval_limit
if: github.event_name == 'workflow_dispatch'
run: |
if ! [[ "${{ github.event.inputs.eval_limit }}" =~ ^[1-9][0-9]*$ ]]; then
echo "Error: eval_limit must be a positive integer, got: ${{ github.event.inputs.eval_limit }}"
exit 1
fi

- name: Validate SDK reference (semantic version check)
if: github.event_name == 'workflow_dispatch'
env:
Expand Down
Loading