Skip to content

Insist on integration tests on the model addition AGENTS.MD#2293

Merged
juanmichelini merged 1 commit intomainfrom
juanmichelini-patch-1
Mar 4, 2026
Merged

Insist on integration tests on the model addition AGENTS.MD#2293
juanmichelini merged 1 commit intomainfrom
juanmichelini-patch-1

Conversation

@juanmichelini
Copy link
Copy Markdown
Collaborator

@juanmichelini juanmichelini commented Mar 3, 2026

Summary

We tested the AGENTS.MD and it performed fine but did not run the integration test action.
This change adds the integration tests to an earlier plan, so that it is more likely to be run.
Updated instructions for adding models and testing.

Checklist

  • If the PR is changing/adding functionality, are there tests to reflect this?
  • If there is an example, have you run the example to make sure that it works?
  • If there are instructions on how to run the code, have you followed the instructions and made sure that it works?
  • If the feature is significant enough to require documentation, is there a PR open on the OpenHands/docs repository with the same branch name?
  • Is the github CI passing?

Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.12-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:1c57c84-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-1c57c84-python \
  ghcr.io/openhands/agent-server:1c57c84-python

All tags pushed for this build

ghcr.io/openhands/agent-server:1c57c84-golang-amd64
ghcr.io/openhands/agent-server:1c57c84-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:1c57c84-golang-arm64
ghcr.io/openhands/agent-server:1c57c84-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:1c57c84-java-amd64
ghcr.io/openhands/agent-server:1c57c84-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:1c57c84-java-arm64
ghcr.io/openhands/agent-server:1c57c84-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:1c57c84-python-amd64
ghcr.io/openhands/agent-server:1c57c84-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-amd64
ghcr.io/openhands/agent-server:1c57c84-python-arm64
ghcr.io/openhands/agent-server:1c57c84-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-arm64
ghcr.io/openhands/agent-server:1c57c84-golang
ghcr.io/openhands/agent-server:1c57c84-java
ghcr.io/openhands/agent-server:1c57c84-python

About Multi-Architecture Support

  • Each variant tag (e.g., 1c57c84-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., 1c57c84-python-amd64) are also available if needed

…GMODEL.md

Updated instructions for adding models and testing.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

API breakage checks (Griffe)

Result: Failed

Log excerpt (first 1000 characters)

============================================================
Checking openhands-sdk (openhands.sdk)
============================================================
Comparing openhands-sdk 1.11.5 against 1.11.4
::notice title=openhands-sdk API::Ignoring Field metadata-only change (non-breaking): load_public_skills
::notice title=openhands-sdk API::Ignoring Field metadata-only change (non-breaking): temperature
::warning file=openhands-sdk/openhands/sdk/llm/llm.py,line=196,title=LLM.top_p::Attribute value was changed: `Field(default=1.0, ge=0, le=1)` -> `Field(default=None, ge=0, le=1, description='Nucleus sampling parameter. Defaults to None (uses provider default). Set to a value between 0 and 1 to control diversity of outputs.')`
::error title=SemVer::Breaking changes detected (1); require at least minor version bump from 1.11.x, but new is 1.11.5

============================================================
Checking openhands-workspace (openhands.workspace)
============================

Action log

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

Agent server REST API breakage checks (OpenAPI)

Result: Passed

Action log

Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Pragmatic fix for a real problem (agents weren't running tests). Documentation-only change, no breakage risk. Minor typo noted inline.

- Do not touch any other files, tests, imports, or configurations
- If you think something is broken, it's probably not - leave it alone
- Test the PR branch with the integration test action.
- Add a link to the integrations test to the PR.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: Typo - should be "integration test" (singular) not "integrations test" for consistency with line 38.

Also, "Add a link to the integration test" is vague - link to what exactly? The workflow run URL? Consider being more specific, e.g., "Add a link to the integration test workflow run in a PR comment."

@juanmichelini juanmichelini merged commit eab666f into main Mar 4, 2026
30 checks passed
@juanmichelini juanmichelini deleted the juanmichelini-patch-1 branch March 4, 2026 00:02
zparnold added a commit to zparnold/software-agent-sdk that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants