Insist on integration tests on the model addition AGENTS.MD#2293
Merged
juanmichelini merged 1 commit intomainfrom Mar 4, 2026
Merged
Insist on integration tests on the model addition AGENTS.MD#2293juanmichelini merged 1 commit intomainfrom
juanmichelini merged 1 commit intomainfrom
Conversation
…GMODEL.md Updated instructions for adding models and testing.
Contributor
API breakage checks (Griffe)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
all-hands-bot
approved these changes
Mar 3, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Pragmatic fix for a real problem (agents weren't running tests). Documentation-only change, no breakage risk. Minor typo noted inline.
| - Do not touch any other files, tests, imports, or configurations | ||
| - If you think something is broken, it's probably not - leave it alone | ||
| - Test the PR branch with the integration test action. | ||
| - Add a link to the integrations test to the PR. |
Collaborator
There was a problem hiding this comment.
🟡 Suggestion: Typo - should be "integration test" (singular) not "integrations test" for consistency with line 38.
Also, "Add a link to the integration test" is vague - link to what exactly? The workflow run URL? Consider being more specific, e.g., "Add a link to the integration test workflow run in a PR comment."
zparnold
added a commit
to zparnold/software-agent-sdk
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We tested the AGENTS.MD and it performed fine but did not run the integration test action.
This change adds the integration tests to an earlier plan, so that it is more likely to be run.
Updated instructions for adding models and testing.
Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:1c57c84-pythonRun
All tags pushed for this build
About Multi-Architecture Support
1c57c84-python) is a multi-arch manifest supporting both amd64 and arm641c57c84-python-amd64) are also available if needed