Skip to content

Insist on integration tests on the model addition AGENTS.MD #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmichelini merged 1 commit into from
Mar 4, 2026
Merged

Insist on integration tests on the model addition AGENTS.MD #2293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/run-eval/ADDINGMODEL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ This file (`resolve_model_config.py`) defines models available for evaluation. M
- Add ONE new test function (follow existing pattern exactly)
- Add to feature lists in model_features.py ONLY if needed for your model
- Do not touch any other files, tests, imports, or configurations
- If you think something is broken, it's probably not - leave it alone
- Test the PR branch with the integration test action.
- Add a link to the integrations test to the PR.
Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: Typo - should be "integration test" (singular) not "integrations test" for consistency with line 38.

Also, "Add a link to the integration test" is vague - link to what exactly? The workflow run URL? Consider being more specific, e.g., "Add a link to the integration test workflow run in a PR comment."

- If you think something is broken, it's probably not - add a comment to the PR.

## Files to Modify

Expand Down
Loading