Fix unreachable str handling in string_view wrapper methods#210
Merged
poshul merged 2 commits intostl17_supportfrom Nov 28, 2025
Merged
Fix unreachable str handling in string_view wrapper methods#210poshul merged 2 commits intostl17_supportfrom
poshul merged 2 commits intostl17_supportfrom
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update bytes parameter type in STL container converters tests
Fix unreachable str handling in string_view wrapper methods
Nov 28, 2025
Collaborator
|
Ah I see Sam merged it. Wasn’t sure - I think cleanup is not tested so nothing failed and I was not sure how to properly test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getStringViewLengthandstringViewToStringmethods declaredbytesparameter types, but containedstrhandling logic that was unreachable since Cython enforces type constraints at the C boundary.Changes
bytestype annotation fromsvparameter (now untyped/object)Union[bytes, str]acceptance.encode()logic now reachable💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.