Skip to content

Fix unreachable str handling in string_view wrapper methods #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poshul merged 2 commits into from
Nov 28, 2025
Merged

Fix unreachable str handling in string_view wrapper methods #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d077b5f
Initial plan
Copilot Nov 28, 2025
d2cb3f0
Fix bytes parameter type to untyped for string_view wrappers
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_files/new_stl_test.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,9 @@ cdef class _NewSTLTest:
py_result = <int>_r
return py_result

def getStringViewLength(self, bytes sv ):
def getStringViewLength(self, sv ):
"""
getStringViewLength(self, sv: bytes ) -> int
getStringViewLength(self, sv: Union[bytes, str] ) -> int
"""
assert isinstance(sv, (bytes, str)), 'arg sv wrong type'
cdef bytes v0
Expand All @@ -225,9 +225,9 @@ cdef class _NewSTLTest:
py_result = <size_t>_r
return py_result

def stringViewToString(self, bytes sv ):
def stringViewToString(self, sv ):
"""
stringViewToString(self, sv: bytes ) -> bytes
stringViewToString(self, sv: Union[bytes, str] ) -> bytes
"""
assert isinstance(sv, (bytes, str)), 'arg sv wrong type'
cdef bytes v0
Expand Down
Loading