Draft
Conversation
Contributor
|
2289ec9 to
560eb50
Compare
560eb50 to
536a949
Compare
0f5158e to
536a949
Compare
8000ceb to
a4f9a1f
Compare
a4f9a1f to
23b0218
Compare
ca988aa to
33cc939
Compare
33cc939 to
c35b312
Compare
5fcded2 to
2cca888
Compare
Wadjetz
added a commit
that referenced
this pull request
Mar 24, 2026
Part of #15653 This PR adapt the `GET /train_schedules/{id}/simulation` with new exceptions Rename query string to exception_id Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
a70aa80 to
463cc1d
Compare
463cc1d to
229b162
Compare
theocrsb
pushed a commit
that referenced
this pull request
Mar 26, 2026
Part of #15653 This PR adapt the `GET /train_schedules/{id}/simulation` with new exceptions Rename query string to exception_id Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
6076314 to
c84a410
Compare
theocrsb
pushed a commit
that referenced
this pull request
Mar 30, 2026
Part of #15653 This PR adapt the `GET /train_schedules/{id}/simulation` with new exceptions Rename query string to exception_id Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
b7e4444 to
302e525
Compare
fix #15428 This PR adapts the `GET /timetable/{id}/train_schedules` endpoint to retrieve the new exceptions. To reduce the amount of refactoring, we convert the new exceptions into the old ones; later, we will replace them entirely. This PR targets a feature branch and breaks e2e tests. We will fix the tests later (normally, they should fix themselves when we complete the refactoring). Signed-off-by: Egor <egor@berezify.fr>
This PR add apply_train_schedule_exception function to compute train_occurrence from new exception Signed-off-by: Egor <egor@berezify.fr>
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
Add `iter_occurrences_v2` and `get_created_occurrences_exceptions_v2` functions that use the new exceptions It used in endpoints, like conflicts, requirements and others Signed-off-by: Egor <egor@berezify.fr>
…15797) This PR add a small utility function to retrieve exceptions by ids and timetable useful for multiple endpoints Signed-off-by: Egor <egor@berezify.fr>
Part of #15202 This PR adapt the `/train_schedules/{id}/etcs_braking_curves` to use the new exception table Rename the query string to `exception_id` Fix frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
closes #15209 This PR updates the import logic to move exceptions from paced.exceptions into the new dedicated exceptions table. Instead of being included in the TrainSchedule payload, exceptions are now created separately via the exceptions endpoint. Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
…ble (#15690) fix #15593 part of #15202 adapt `GET /train_schedule/{id}/path` endpoint with new exceptions with incremental refactoring to be able to have small PR and adapt endpoints one by one - [x] Use exception id in query string - [x] Adapts tests to use new exceptions > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
Part of #15653 This PR adapt the `GET /train_schedules/{id}/simulation` with new exceptions Rename query string to exception_id Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
part of #15202 This PR adapt `GET /timetable/{id}/conflicts` with new exceptions Fix tests: exceptions must now be created through the timetable/{id}/train_schedule_exceptions endpoint > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
Part of #15202 This PR adapt the `/train_schedules/track_occupancy`endpoint to use the new exceptions table It also requires the timetable_id as a parameter, as exceptions are now related to a timetable and not just to a train schedule Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
fix #15592 part of #15202 Adapt GET /paced_train/simulation_summary endpoint with new exceptions Add timetable_id parameter to the simulation summary endpoint, because exceptions are now linked to a timetable Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
…#15930) Part of #15202 This PR adapt the `/level_crossing_occupancy`endpoint to use the new exceptions table It also requires the timetable_id as a parameter, as exceptions are now related to a timetable and not just to a train schedule > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
Part of #15202 This PR adapt the `/train_schedules/occupancy_blocks`endpoint to use the new exceptions table It also requires the timetable_id as a parameter, as exceptions are now related to a timetable and not just to a train schedule Rename exception_key into exception_id Fix tests and frontend > [!NOTE] > This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed. Signed-off-by: Egor <egor@berezify.fr>
302e525 to
1c564a5
Compare
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the feature branch for new train schedule exceptions.
All included PRs have already been reviewed.
Part of #15202
PRs: