Skip to content

editoast: adapt simulation endpoint with new exceptions#15695

Merged
Wadjetz merged 1 commit intofeatures/train-schedule-exceptionsfrom
ebe/editoast/adapt-simulation-endpoint
Mar 24, 2026
Merged

editoast: adapt simulation endpoint with new exceptions#15695
Wadjetz merged 1 commit intofeatures/train-schedule-exceptionsfrom
ebe/editoast/adapt-simulation-endpoint

Conversation

@Wadjetz
Copy link
Copy Markdown
Member

@Wadjetz Wadjetz commented Mar 11, 2026 •
edited
Loading

Part of #15653

This PR adapt the GET /train_schedules/{id}/simulation with new exceptions
Rename query string to exception_id
Fix tests and frontend

Note

This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed.

@Wadjetz Wadjetz self-assigned this Mar 11, 2026
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Mar 11, 2026
@Wadjetz Wadjetz changed the base branch from dev to features/train-schedule-exceptions March 11, 2026 15:58
@Wadjetz Wadjetz force-pushed the features/train-schedule-exceptions branch 2 times, most recently from 8000ceb to a4f9a1f Compare March 16, 2026 12:59
@younesschrifi younesschrifi force-pushed the features/train-schedule-exceptions branch from a4f9a1f to 23b0218 Compare March 17, 2026 09:28
@theocrsb theocrsb force-pushed the features/train-schedule-exceptions branch from 23b0218 to 85ffd09 Compare March 17, 2026 11:11
@Wadjetz Wadjetz force-pushed the ebe/editoast/adapt-simulation-endpoint branch from 22076c2 to fb71deb Compare March 17, 2026 16:49
@github-actions github-actions bot removed area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Mar 17, 2026
@theocrsb theocrsb force-pushed the features/train-schedule-exceptions branch from ca988aa to 33cc939 Compare March 18, 2026 08:20
@Wadjetz Wadjetz force-pushed the features/train-schedule-exceptions branch from 33cc939 to c35b312 Compare March 19, 2026 09:02
@Wadjetz Wadjetz mentioned this pull request Mar 19, 2026
Draft
21 tasks
@Wadjetz Wadjetz force-pushed the ebe/editoast/adapt-simulation-endpoint branch 2 times, most recently from bde5061 to a4913c0 Compare March 19, 2026 11:11
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules kind:api-change labels Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

@Wadjetz Wadjetz changed the title editoast: adapt simulation endpoint editoast: adapt simulation endpoint with new exceptions Mar 19, 2026
@Wadjetz Wadjetz marked this pull request as ready for review March 19, 2026 11:14
@Wadjetz Wadjetz requested a review from a team as a code owner March 19, 2026 11:14
@Wadjetz Wadjetz requested a review from a team as a code owner March 19, 2026 11:14
@Wadjetz Wadjetz mentioned this pull request Mar 19, 2026
Merged
@theocrsb theocrsb force-pushed the features/train-schedule-exceptions branch from 5e9a382 to 9f4b508 Compare March 20, 2026 09:01
@theocrsb theocrsb requested a review from a team as a code owner March 20, 2026 09:01
@theocrsb theocrsb requested review from shenriotpro and removed request for a team March 20, 2026 09:01
@Wadjetz Wadjetz force-pushed the ebe/editoast/adapt-simulation-endpoint branch from a4913c0 to 9d1fc76 Compare March 20, 2026 09:38
shenriotpro
shenriotpro approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this concerns our data repo

@Wadjetz
Copy link
Copy Markdown
Member Author

Wadjetz commented Mar 20, 2026

Doesn't look like this concerns our data repo

Yes, sorry, i don't know why it trigger data review

@theocrsb theocrsb force-pushed the features/train-schedule-exceptions branch from 5fcded2 to 2cca888 Compare March 23, 2026 07:16
@Wadjetz Wadjetz force-pushed the ebe/editoast/adapt-simulation-endpoint branch from 9d1fc76 to f1f1b0b Compare March 23, 2026 15:47
@Wadjetz
editoast: adapt simulation endpoint with new exceptions
2565b9a 
Signed-off-by: Egor <egor@berezify.fr>
@woshilapin
Copy link
Copy Markdown
Contributor

woshilapin commented Mar 24, 2026

Doesn't look like this concerns our data repo

Yes, sorry, i don't know why it trigger data review

It does trigger a review of the Data because the feature branch does contain modifications of the /railway_manager_interface, so each time the feature branch is rebased, then all commits are different in the current PR, therefore containing the other commits that touches RaiMI. I guess that is one of the annoying problem with long-live feature branch. Not sure that it can be handled smoothly at this point.

@Wadjetz Wadjetz force-pushed the ebe/editoast/adapt-simulation-endpoint branch from f1f1b0b to 2565b9a Compare March 24, 2026 10:29
@Wadjetz Wadjetz requested a review from a team as a code owner March 24, 2026 10:29
@Wadjetz Wadjetz requested a review from eckter March 24, 2026 10:29
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Mar 24, 2026
@Wadjetz Wadjetz merged commit c84cf04 into features/train-schedule-exceptions Mar 24, 2026
29 of 30 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast/adapt-simulation-endpoint branch March 24, 2026 10:59
theocrsb pushed a commit that referenced this pull request Mar 26, 2026
@Wadjetz @theocrsb
editoast: adapt simulation endpoint with new exceptions (#15695)
2f6a549 
Part of #15653

This PR adapt the `GET /train_schedules/{id}/simulation` with new
exceptions
Rename query string to exception_id
Fix tests and frontend

> [!NOTE]
> This PR targets a feature branch and may contain all its commits, as
it has not been rebased yet. Only the last commit need to be reviewed.

Signed-off-by: Egor <egor@berezify.fr>
theocrsb pushed a commit that referenced this pull request Mar 30, 2026
@Wadjetz @theocrsb
editoast: adapt simulation endpoint with new exceptions (#15695)
6303d60 
Part of #15653

This PR adapt the `GET /train_schedules/{id}/simulation` with new
exceptions
Rename query string to exception_id
Fix tests and frontend

> [!NOTE]
> This PR targets a feature branch and may contain all its commits, as
it has not been rebased yet. Only the last commit need to be reviewed.

Signed-off-by: Egor <egor@berezify.fr>
theocrsb pushed a commit that referenced this pull request Mar 31, 2026
@Wadjetz @theocrsb
editoast: adapt simulation endpoint with new exceptions (#15695)
87ac920 
Part of #15653

This PR adapt the `GET /train_schedules/{id}/simulation` with new
exceptions
Rename query string to exception_id
Fix tests and frontend

> [!NOTE]
> This PR targets a feature branch and may contain all its commits, as
it has not been rebased yet. Only the last commit need to be reviewed.

Signed-off-by: Egor <egor@berezify.fr>
theocrsb pushed a commit that referenced this pull request Apr 3, 2026
@Wadjetz @theocrsb
editoast: adapt simulation endpoint with new exceptions (#15695)
ada7670 
Part of #15653

This PR adapt the `GET /train_schedules/{id}/simulation` with new
exceptions
Rename query string to exception_id
Fix tests and frontend

> [!NOTE]
> This PR targets a feature branch and may contain all its commits, as
it has not been rebased yet. Only the last commit need to be reviewed.

Signed-off-by: Egor <egor@berezify.fr>
theocrsb pushed a commit that referenced this pull request Apr 4, 2026
@Wadjetz @theocrsb
editoast: adapt simulation endpoint with new exceptions (#15695)
26d0ff9 
Part of #15653

This PR adapt the `GET /train_schedules/{id}/simulation` with new
exceptions
Rename query string to exception_id
Fix tests and frontend

> [!NOTE]
> This PR targets a feature branch and may contain all its commits, as
it has not been rebased yet. Only the last commit need to be reviewed.

Signed-off-by: Egor <egor@berezify.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woshilapin woshilapin woshilapin approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@shenriotpro shenriotpro shenriotpro approved these changes

@flomonster flomonster Awaiting requested review from flomonster

@younesschrifi younesschrifi Awaiting requested review from younesschrifi

@eckter eckter Awaiting requested review from eckter eckter is a code owner automatically assigned from OpenRailAssociation/osrd-core

Assignees

@Wadjetz Wadjetz

Labels

area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services kind:api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wadjetz @woshilapin @SharglutDev @shenriotpro