editoast: refactor train schedule exceptions fixtures#16008
Open
Wadjetz wants to merge 1 commit intofeatures/train-schedule-exceptionsfrom
Open
editoast: refactor train schedule exceptions fixtures#16008Wadjetz wants to merge 1 commit intofeatures/train-schedule-exceptionsfrom
Wadjetz wants to merge 1 commit intofeatures/train-schedule-exceptionsfrom
Conversation
20 tasks
younesschrifi
approved these changes
Mar 31, 2026
theocrsb
force-pushed
the
features/train-schedule-exceptions
branch
from
302e525 to
1c564a5
Compare
theocrsb
requested review from
Morgane-SJK and
bougue-pe
and removed request for
a team
Wadjetz
force-pushed
the
ebe/editoast/refactor-train_schedule_exception-fixtures
branch
from
a60e00c to
c5866fb
Compare
Morgane-SJK
approved these changes
Apr 1, 2026
woshilapin
approved these changes
Apr 1, 2026
Contributor
woshilapin
left a comment
woshilapin
left a comment
There was a problem hiding this comment.
I like this proposition, when a fixture can be entirely contained inside an impl block of the concerned object, I believe it makes sense.
Wadjetz
force-pushed
the
ebe/editoast/refactor-train_schedule_exception-fixtures
branch
from
c5866fb to
be0febb
Compare
woshilapin
reviewed
Apr 1, 2026
| #[cfg(any(test, feature = "testing"))] | ||
| impl TrainScheduleExceptionChangeGroups { | ||
| pub fn fake_created() -> Self { | ||
| pub fn fake() -> Self { |
Contributor
There was a problem hiding this comment.
Maybe this one too can be changed to fixture_something?
Signed-off-by: Egor <egor@berezify.fr>
Wadjetz
force-pushed
the
ebe/editoast/refactor-train_schedule_exception-fixtures
branch
from
be0febb to
fe60179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15202
Refactor train schedule exceptions fixtures and test that still use old exceptions types
Note
This PR targets a feature branch and may contain all its commits, as it has not been rebased yet. Only the last commit need to be reviewed.