Skip to content

Conversation

@vkrasnovyd
Copy link
Contributor

@vkrasnovyd vkrasnovyd commented Oct 1, 2025

Changes needed to integrate into the backend the changes from the updated vote service described in this version of the migration file from the vote service

Deleted files

Reason: Actions were moved to the vote service:

  • poll.create
  • poll.update
  • poll.delete
  • poll.start
  • poll.stop
  • poll.publish
  • poll.anonymize
  • poll.reset

Reason: Cascade delete - internal actions used only in poll actions:

  • vote.delete (poll.reset)
  • vote.anonymize (poll.anonymize)
  • poll: base, mixins
  • docs for the deleted actions

Reason: Deletion of the 'option' collection in meta PR:

  • option.create
  • option.update
  • option.delete
  • option.set_auto_fields
  • poll.set_state (internal action used only by option.update)

Reason: Cascade delete - internal actions used only in poll and option collections:

  • vote.create (poll.stop, option.create, option.update)
  • vote.update (option.update)
  • vote.user_token_helper.py (poll and option actions)
  • poll_candidate.create (poll_candidate_list.create)
  • poll_candidate.delete (not used)
  • poll_candidate_list.create (option.create)
  • poll_candidate_list.delete (option.delete)
  • poll: base, functions, mixins files

Other changes

  • export_meeting: now the votes are exported manually because there's no direct relation to the meeting
  • checker.check_relation: Added special logic for the vote collection - to theck the relation to the meeting through the poll
  • Updated methods in the vote service adapter to match the methods of the new vote service, changed VOTE_PATH in the env.py from internal to system. Both are described in the current vote service readme

Notes to further meta cleanup

Meta requires more cleanup (changes will also have to be implemented in the other services including backend).

Fields to delete

Reason: group consistency accross settings of different poll types
poll.backend was deleted, meeting.poll_default_backend is already deleted as well:

  • meeting.motion_poll_default_backend
  • meeting.assignment_poll_default_backend

poll.onehundred_percent_base was deleted, no more need for defaults:

  • meeting.poll_default_onehundred_percent_base
  • meeting.motion_poll_default_onehundred_percent_base
  • meeting.assignment_poll_default_onehundred_percent_base

poll.max_votes_per_option was deleted:

  • meeting.assignment_poll_enable_max_votes_per_option

poll.live_voting_enabled was deleted:

  • meeting.poll_default_live_voting_enabled

Defaults/options to change

Deleted field poll.type:

  • meeting.poll_default_type
  • meeting.motion_poll_default_type
  • meeting.assignment_poll_default_type

Deleted field poll.method:

  • meeting.poll_default_method (no default value)
  • meeting.motion_poll_default_method (default value == "YNA")
  • meeting.assignment_poll_default_method (default value == "YNA")

@vkrasnovyd vkrasnovyd force-pushed the feature/new-vote-service branch from c5b1c0b to 6521e1f Compare October 6, 2025 07:47
@hjanott hjanott added this to the 4.x milestone Oct 16, 2025
@vkrasnovyd vkrasnovyd force-pushed the feature/new-vote-service branch 2 times, most recently from cd68147 to 0777b44 Compare October 30, 2025 19:25
@vkrasnovyd vkrasnovyd closed this Nov 3, 2025
@vkrasnovyd vkrasnovyd deleted the feature/new-vote-service branch November 3, 2025 15:13
@vkrasnovyd vkrasnovyd restored the feature/new-vote-service branch November 3, 2025 15:13
@vkrasnovyd vkrasnovyd reopened this Nov 3, 2025
@vkrasnovyd vkrasnovyd changed the title [rel-db] Feature/new_vote_service [rel-db] Feature/new_vote_service - Part 1 Nov 3, 2025
@vkrasnovyd vkrasnovyd force-pushed the feature/new-vote-service branch 2 times, most recently from 72cbfed to 87326e0 Compare November 4, 2025 08:38
@vkrasnovyd vkrasnovyd changed the title [rel-db] Feature/new_vote_service - Part 1 [rel-db] Feature/new_vote_service Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants