Skip to content

chore!: drop GUI#39

Merged
JarbasAl merged 2 commits intodevfrom
drop_gui
Mar 1, 2026
Merged

chore!: drop GUI#39
JarbasAl merged 2 commits intodevfrom
drop_gui

Conversation

@JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 1, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Removed GUI network setup integration module and associated user interface components.
  • Chores

    • Updated dependency version constraints for better compatibility.
    • Removed unused dependency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb1937 and cef2a52.

📒 Files selected for processing (1)
  • ovos_PHAL_plugin_network_manager/__init__.py
📝 Walkthrough

Walkthrough

This PR removes GUI client functionality from the Network Manager plugin, including the GUISetup class, all QML UI components for network selection and management, animation assets, and associated dependencies. The core plugin structure remains with minimal adjustments to dependencies and import statements.

Changes

Cohort / File(s) Summary
Documentation and Plugin Initialization
README.md, ovos_PHAL_plugin_network_manager/__init__.py
Removed Plasma Network Manager documentation line and deleted GUISetup import/initialization from plugin startup. No functional impact to core plugin operations.
Core GUI Implementation
ovos_PHAL_plugin_network_manager/gui.py
Removed entire GUISetup class (~209 lines), eliminating all GUI event handlers, network display flows, WIFI plugin interactions, state management, and GUI lifecycle integration with the bus.
QML UI Components
ovos_PHAL_plugin_network_manager/gui/qt5/*.qml, ovos_PHAL_plugin_network_manager/gui/qt5/networking/*.qml
Deleted all QML components including main loaders, network selection/management screens, connection status displays, bottom action buttons, and network item handlers. Removes entire UI interaction and navigation flows for network management (~1,200 lines).
Animation Assets
ovos_PHAL_plugin_network_manager/gui/qt5/networking/animations/*
Removed Lottie JSON animation files for connecting and security states previously referenced by GUI components.
Dependencies
requirements.txt
Updated ovos-plugin-manager (\>=2.1.0,<3.0.0) and ovos-utils (\>=0.0.32,<2.0.0) version constraints; removed dbus-next package dependency.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Buttons and screens have had their day,
QML widgets swept away,
The GUI says farewell with grace,
Leaving core code in its place!
Simpler networks, cleaner sight,
One less layer—oh what light!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore!: drop GUI' accurately and concisely describes the main change: the complete removal of GUI-related code and components from the plugin.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drop_gui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #40

coderabbitai bot added a commit that referenced this pull request Mar 1, 2026
Docstrings generation was requested by @JarbasAl.

* #39 (comment)

The following files were modified:

* `ovos_PHAL_plugin_network_manager/__init__.py`
Docstrings generation was requested by @JarbasAl.

* #39 (comment)

The following files were modified:

* `ovos_PHAL_plugin_network_manager/__init__.py`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@JarbasAl JarbasAl merged commit b920e44 into dev Mar 1, 2026
3 checks passed
@JarbasAl JarbasAl deleted the drop_gui branch March 1, 2026 15:31
JarbasAl added a commit that referenced this pull request Mar 1, 2026
* allow OPM 1.X:X

* Update release_workflow.yml

* Update publish_stable.yml

* Update release_workflow.yml

* Merge pull request #31 from OpenVoiceOS/renovate/configure

Configure Renovate

* Increment Version to 1.3.5a1

* Update Changelog

* Update dependency python to 3.14 (#32)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Increment Version to 1.3.5a2

* Update Changelog

* Update dependency ovos-plugin-manager to v2 (#37)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Increment Version to 1.3.5a3

* Update Changelog

* chore!: drop GUI (#39)

* chore!: drop GUI

* 📝 Add docstrings to `drop_gui` (#40)

Docstrings generation was requested by @JarbasAl.

* #39 (comment)

The following files were modified:

* `ovos_PHAL_plugin_network_manager/__init__.py`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Increment Version to 1.3.5a4

* Update Changelog

* Update publish_stable.yml

* Change Python version to 3.11 in release workflow

Updated Python version from 3.14 to 3.11 in the release workflow.

* Remove PR merged condition from publish_alpha job

Removed conditional check for merged pull requests in the publish_alpha job.

* Increment Version to 1.3.5a5

---------

Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant