Fix resolution of the virtual fact on FreeBSD#16
Merged
Conversation
bastelfreak
previously approved these changes
Jun 16, 2025
smortex
force-pushed
the
fix-freebsd-virtual-fact
branch
from
24d6341 to
2214d22
Compare
Member
Author
|
I fixed the mistakes that caused the jRuby failures. Interesting it did not failed with other implementations of Ruby 🤷 |
jessereynolds
previously approved these changes
Jun 26, 2025
Contributor
jessereynolds
left a comment
jessereynolds
left a comment
There was a problem hiding this comment.
I like this mechanism to detect if an implementation for the given os type exists.
smortex
dismissed
jessereynolds’s stale review
The merge-base changed after approval.
jessereynolds
previously approved these changes
Jun 26, 2025
smortex
dismissed
jessereynolds’s stale review
The merge-base changed after approval.
bastelfreak
previously approved these changes
Jun 26, 2025
smortex
dismissed
bastelfreak’s stale review
The merge-base changed after approval.
bastelfreak
previously approved these changes
Jun 26, 2025
smortex
dismissed
bastelfreak’s stale review
The merge-base changed after approval.
bastelfreak
previously approved these changes
Jun 26, 2025
smortex
dismissed
bastelfreak’s stale review
The merge-base changed after approval.
bastelfreak
previously approved these changes
Jun 26, 2025
smortex
force-pushed
the
fix-freebsd-virtual-fact
branch
from
2214d22 to
8b39081
Compare
bastelfreak
previously approved these changes
Jun 26, 2025
We should not call Linux-specific code from a non-Linux system. This cross-platform utility class needs to skip Linux code when running on a non-linux platform.
smortex
force-pushed
the
fix-freebsd-virtual-fact
branch
from
8b39081 to
80b3fef
Compare
bastelfreak
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not call Linux-specific code from a non-Linux system. Before #15, the Linux-specific code was unexpectedly loaded, and the Linux resolver was non-functional on FreeBSD, causing a warning to be output. With #15, the Linux specific code is not loaded anymore, breaking further the fact resolution.
In order to fix this, the virtual_detector code needs to either be split into platform-specific pieces, or take care to only call platform-specific code on these platforms. Given this is a utility class, I chose the second route, and since the Linux-specific code is now only loaded on Linux, rely on the namespace existing or not to determine if we should run that code.
Originally submitted as:
puppetlabs/facter#2744