Skip to content

Conversation

ernestognw
Copy link
Member

Follow up to #121

@ernestognw ernestognw marked this pull request as ready for review May 17, 2025 04:25
@ernestognw ernestognw requested a review from a team as a code owner May 17, 2025 04:25
@ernestognw ernestognw changed the title Add ERC-7579 modules documentation Add ERC-7579 modules docs and EIP-7702 note in accounts docs May 17, 2025
@arr00
Copy link
Collaborator

arr00 commented May 19, 2025

We should add the interfaces to the API section of the docs.

@ernestognw
Copy link
Member Author

We should add the interfaces to the API section of the docs.

Yeah, the issue with those is a bit more complex since they come from the vanilla repository. #30

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where and exactly how, but I would like to briefly mention the benefits of implicitly using ERC-7913 building blocks on the Social Recovery example, since I think, and this is very opinionated, that it is a valuable feature that makes a compelling reason enough to choose this over other implementations, on top of the great composability and extensibility provided. Wdyt? @ernestognw

Copy link
Member Author

@ernestognw ernestognw May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think standards should be sold. I mean that a good standard solves an issue cleanly, and I think this is the case. The recommendation should be "just use ERC-7913" because it's simply the best way to approach support for arbitrary authorization types.

Instead, maybe users would benefit from understanding how to bring ERC-7913 to their use cases. They should be guided about when to use each variant (SingerERC7913, MultisignerERC7913, ERC7579Multisig, ERC7913Utils, ERC7913RSAVerifier, ERC7913ZKVerifier, ERC7913P256Verifier and beyond)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I get what you say. Is it that the reasons of why using an ERC7579Multisig aren't explained? That'd be true.

I just updated with a bit more context in 8980e0c

arr00
arr00 previously approved these changes May 19, 2025
@ernestognw
Copy link
Member Author

Thanks for reviewing both! Merging since the previous change was minimal

@ernestognw ernestognw merged commit 317e673 into master May 19, 2025
11 checks passed
ernestognw added a commit that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants