Simplify ERC7579 Executors validation pattern #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
commented
May 17, 2025
| @@ -15,7 +15,7 @@ const { shouldBehaveLikeERC7579Module } = require('./ERC7579Module.behavior'); | |||
|
|
|||
| async function fixture() { | |||
| // Deploy ERC-7579 validator module | |||
| const mock = await ethers.deployContract('$ERC7579MultisigExecutorMock', ['MultisigExecutor', '1']); | |||
| const mock = await ethers.deployContract('$ERC7579ExecutorMock'); | |||
There was a problem hiding this comment.
Your smell was correct @gonzaotc 😄
ernestognw
added a commit
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, this PR simplifies by removing forced design choices like having the account authorized to cancel by default. I initially thought overriding would be the best pattern, but I'm playing with this on Wizard and writing the docs (#157), and these changes would make it fit cleaner.
Core Design Change
ERC7579Executor.sol
_validateExecutionto return only calldata (removed boolean flag)ERC7579InvalidExecutionerrorERC7579DelayedExecutor.sol
_validateCanceland_validateScheduleto void functions that should revert on failure. Left virtual.ERC7579ExecutorUnauthorizedCancellationandERC7579ExecutorUnauthorizedScheduleerrors