Skip to content

Test encoding of addresses with leading zeros #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Test encoding of addresses with leading zeros #6107

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f437257
Test encoding of addresses with leading zeros
Amxx Nov 13, 2025
60b70b7
Update test/utils/RLP.test.js
Amxx Nov 14, 2025
6a86e31
add fuzzing test
Amxx Nov 14, 2025
08d217f
Merge branch 'testing/rlp-encoding-addresses' of https://github.com/A…
Amxx Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions test/utils/RLP.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const { ethers } = require('hardhat');
const { expect } = require('chai');
const { loadFixture } = require('@nomicfoundation/hardhat-network-helpers');

const { product } = require('../helpers/iterate');
const { generators } = require('../helpers/random');

async function fixture() {
Expand Down Expand Up @@ -33,11 +34,15 @@ describe('RLP', function () {
});

it('encode/decode addresses', async function () {
const addr = generators.address();
const expected = ethers.encodeRlp(addr);

await expect(this.mock.$encode_address(addr)).to.eventually.equal(expected);
await expect(this.mock.$decodeAddress(expected)).to.eventually.equal(addr);
for (const addr of [
ethers.ZeroAddress, // zero address
'0x0000F90827F1C53a10cb7A02335B175320002935', // address with heading zeros
generators.address(), // random address
]) {
const expected = ethers.encodeRlp(addr);
await expect(this.mock.$encode_address(addr)).to.eventually.equal(expected);
await expect(this.mock.$decodeAddress(expected)).to.eventually.equal(addr);
}
});

it('encode/decode uint256', async function () {
Expand Down Expand Up @@ -146,4 +151,23 @@ describe('RLP', function () {
await expect(this.mock.$decodeBytes(input)).to.be.revertedWithCustomError(this.mock, 'RLPInvalidEncoding');
});
});

it('RLP encoder predict create addresses', async function () {
for (const [from, nonce] of product(
[
ethers.ZeroAddress, // zero address
'0x0000F90827F1C53a10cb7A02335B175320002935', // address with heading zeros
generators.address(), // random address
],
[0n, 1n, 42n, 65535n, ethers.MaxUint256],
)) {
await expect(
this.mock
.$encode_list([this.mock.$encode_address(from), this.mock.$encode_uint256(nonce)])
.then(encoded => ethers.keccak256(encoded)) // hash the encoded content
.then(hash => ethers.dataSlice(hash, 12)) // take the last 20 bytes
.then(ethers.getAddress), // format as (checksummed) address
).to.eventually.equal(ethers.getCreateAddress({ from, nonce }));
}
});
});