docs: clarify Defender Deploy Environment API keys#107
Merged
CoveMB merged 3 commits intoOpenZeppelin:mainfrom May 9, 2025
Merged
docs: clarify Defender Deploy Environment API keys#107CoveMB merged 3 commits intoOpenZeppelin:mainfrom
CoveMB merged 3 commits intoOpenZeppelin:mainfrom
Conversation
Contributor
Author
ericglau
requested changes
May 8, 2025
Co-authored-by: Eric Lau <ericglau@outlook.com>
CoveMB
reviewed
May 9, 2025
Contributor
CoveMB
left a comment
CoveMB
left a comment
There was a problem hiding this comment.
Thanks for contributing ✨
Co-authored-by: Cove Marquis-Bortoli <44323490+CoveMB@users.noreply.github.com>
Contributor
Author
|
@CoveMB thanks for the review, I've added your suggestions. I think this can be merged now. If needed please squash merge it. Thanks. |
3 tasks
CoveMB
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue described in OpenZeppelin/openzeppelin-upgrades#996 by clarifying that the API keys referenced in the Defender integration documentation are specifically from the Production or Test Deploy Environment configured in Defender.
Changes made:
foundry-defender.adocexplaining that the API keys are specifically from the Deploy EnvironmentFixes
Motivation
Users were unclear about which API keys to use for Defender integration. This change makes it explicit that the keys should come from the Deploy Environment in Defender, reducing confusion and improving the developer experience.