test: standardize test function names across codebase

contracts/src/access/control/mod.rs

@@ -448,7 +448,7 @@ mod tests {
     unsafe impl TopLevelStorage for AccessControl {}
 
     #[motsu::test]
-    fn default_role_is_default_admin(
+    fn get_role_admin_returns_default_admin_for_standard_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -457,7 +457,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn default_admin_roles_admin_is_itself(
+    fn get_role_admin_returns_default_admin_for_default_admin_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -467,7 +467,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn non_admin_cannot_grant_role_to_others(
+    fn grant_role_reverts_when_not_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -478,7 +478,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn accounts_can_be_granted_roles_multiple_times(
+    fn grant_role_succeeds_assigning_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -492,7 +492,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn not_granted_roles_can_be_revoked(
+    fn revoke_role_succeeds_removing_ungranted_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -507,7 +507,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn admin_can_revoke_role(
+    fn revoke_role_succeeds_removing_granted_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -523,7 +523,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn non_admin_cannot_revoke_role(
+    fn revoke_role_reverts_when_not_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -538,7 +538,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn roles_can_be_revoked_multiple_times(
+    fn revoke_role_succeeds_removing_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -552,7 +552,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn bearer_can_renounce_role(
+    fn renounce_role_succeeds_removing_own_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -566,7 +566,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn only_sender_can_renounce(
+    fn renounce_role_reverts_when_not_sender(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -578,7 +578,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn roles_can_be_renounced_multiple_times(
+    fn renounce_role_succeeds_removing_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -592,7 +592,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn a_roles_admin_role_can_change(
+    fn _set_role_admin_succeeds_updating_admin_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -604,7 +604,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn the_new_admin_can_grant_roles(
+    fn grant_role_succeeds_assigning_role_with_new_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -618,7 +618,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn the_new_admin_can_revoke_roles(
+    fn revoke_role_succeeds_removing_role_with_new_admins(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -633,7 +633,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn previous_admins_no_longer_grant_roles(
+    fn grant_role_reverts_when_called_by_old_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -647,7 +647,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn previous_admins_no_longer_revoke_roles(
+    fn revoke_role_reverts_when_called_by_old_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -661,7 +661,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn does_not_revert_if_sender_has_role(
+    fn _check_role_succeeds_verifying_granted_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -686,7 +686,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_grant_role_true_if_no_role(
+    fn _grant_role_true_if_no_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -696,7 +696,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_grant_role_false_if_role(
+    fn _grant_role_succeeds_with_existing_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -708,7 +708,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_revoke_role_true_if_role(
+    fn _revoke_role_succeeds_removing_existing_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -721,7 +721,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_revoke_role_false_if_no_role(
+    fn _revoke_role_succeeds_with_nonexistent_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,

contracts/src/access/ownable.rs

@@ -293,7 +293,6 @@ mod tests {
     #[motsu::test]
     fn constructor(contract: Contract<Ownable>, alice: Address) {
         contract.sender(alice).constructor(alice).unwrap();
-
         let owner = contract.sender(alice).owner();
         assert_eq!(owner, alice);
 
@@ -318,7 +317,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn transfers_ownership(
+    fn transfer_ownership_updates_owner_address(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -339,7 +338,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_transferring(
+    fn transfer_ownership_reverts_when_not_owner(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -351,7 +350,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_reaching_stuck_state(
+    fn transfer_ownership_reverts_when_zero_address(
         contract: Contract<Ownable>,
         alice: Address,
     ) {
@@ -366,7 +365,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn loses_ownership_after_renouncing(
+    fn renounce_ownership_sets_zero_address(
         contract: Contract<Ownable>,
         alice: Address,
     ) {
@@ -386,7 +385,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_renouncing(
+    fn renounce_ownership_reverts_when_not_owner(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -398,7 +397,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn recovers_access_using_internal_transfer(
+    fn _transfer_ownership_updates_owner_storage(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,

contracts/src/access/ownable_two_step.rs

@@ -251,7 +251,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn reads_pending_owner(
+    fn pending_owner_returns_current_address(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -263,7 +263,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn initiates_ownership_transfer(
+    fn transfer_ownership_succeeds_updating_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -279,7 +279,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_initiating_transfer(
+    fn transfer_ownership_reverts_when_not_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -297,7 +297,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn accepts_ownership(
+    fn accept_ownership_succeeds_completing_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -314,7 +314,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_pending_owner_from_accepting(
+    fn accept_ownership_reverts_when_not_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -333,7 +333,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn completes_two_step_ownership_transfer(
+    fn transfer_ownership_succeeds_with_complete_flow(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -356,9 +356,11 @@ mod tests {
     }
 
     #[motsu::test]
-    fn renounces_ownership(contract: Contract<Ownable2Step>, alice: Address) {
+    fn renounce_ownership_succeeds_clearing_owner(
+        contract: Contract<Ownable2Step>,
+        alice: Address,
+    ) {
         contract.sender(alice).constructor(alice).unwrap();
-
         contract
             .sender(alice)
             .renounce_ownership()
@@ -367,7 +369,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_renouncing(
+    fn renounce_ownership_reverts_when_not_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -384,7 +386,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn cancels_transfer_on_renounce(
+    fn renounce_ownership_succeeds_clearing_pending_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -401,7 +403,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn allows_owner_to_cancel_transfer(
+    fn transfer_ownership_succeeds_canceling_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -418,7 +420,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn allows_owner_to_overwrite_transfer(
+    fn transfer_ownership_succeeds_overwriting_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,