Skip to content

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented May 19, 2025

Overview

Changed Low Volume 96ch Protocol to Include more Partial Tip Steps

Test Plan and Hands on Testing

  • ran in ABR

Changelog

  • Changed ABR6 protocol to be a different protocol that includes more partial tip steps. This was changed because the protocol previously used was overly simple.
  • Removed unused protocols

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner May 19, 2025 20:34
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.26%. Comparing base (75d0979) to head (29b697c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18395   +/-   ##
=======================================
  Coverage   26.26%   26.26%           
=======================================
  Files        3270     3270           
  Lines      280846   280846           
  Branches    32958    32958           
=======================================
  Hits        73776    73776           
  Misses     207041   207041           
  Partials       29       29           
Flag Coverage Δ
protocol-designer 19.51% <ø> (ø)
step-generation 4.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rclarke0 rclarke0 requested a review from skowalski08 June 5, 2025 16:56
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to this - looks good to me!

@rclarke0 rclarke0 merged commit 5408ea2 into edge Aug 7, 2025
3 checks passed
@rclarke0 rclarke0 deleted the abr-new-lv-protocols branch August 7, 2025 14:17
neo-jesse pushed a commit that referenced this pull request Aug 19, 2025
…ip steps (#18395)

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Changed Low Volume 96ch Protocol to Include more Partial Tip Steps

## Test Plan and Hands on Testing

- ran in ABR

## Changelog

- Changed ABR6 protocol to be a different protocol that includes more
partial tip steps. This was changed because the protocol previously used
was overly simple.
- Removed unused protocols

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants