Skip to content

feat(hardware-testing): upgrade the hardware-qc for pipettes to a protocol. #19141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: chore_release-8.6.0
Choose a base branch
from

Conversation

ryanthecoder
Copy link
Contributor

Overview

This finalizes the QC upgrade to a protocol, it also adjusts some of the liquid class values so that they match the ones from the previous production script.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested review from a team as code owners August 6, 2025 18:51
@ryanthecoder ryanthecoder requested review from jerader and removed request for a team August 6, 2025 18:51
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.50%. Comparing base (95b9d6e) to head (ea3bb8a).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.6.0   #19141      +/-   ##
=======================================================
- Coverage                24.00%   21.50%   -2.51%     
=======================================================
  Files                     3377     3040     -337     
  Lines                   296968   240440   -56528     
  Branches                 31523     9340   -22183     
=======================================================
- Hits                     71301    51702   -19599     
+ Misses                  225649   188738   -36911     
+ Partials                    18        0      -18     
Flag Coverage Δ
app ?
components ?
hardware ?
labware-library ?
opentrons-ai-client ?
protocol-designer 18.92% <ø> (ø)
react-api-client ?
shared-data ?
step-generation 5.37% <ø> (ø)
system-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2054 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanthecoder ryanthecoder force-pushed the EXEC-1370-pt4 branch 2 times, most recently from c52b33c to f8a90f6 Compare August 7, 2025 16:32
@ryanthecoder ryanthecoder added the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Aug 7, 2025
Copy link
Contributor

github-actions bot commented Aug 7, 2025

A PR has been opened to address analyses snapshot changes. Please review the changes here: #19154

ryanthecoder added a commit that referenced this pull request Aug 7, 2025
This PR was requested on the PR
#19141

Co-authored-by: ryanthecoder <[email protected]>
@ryanthecoder ryanthecoder changed the base branch from edge to chore_release-8.6.0 August 8, 2025 19:19
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants