Skip to content

fix(api, app): add `unsafe/flexStacker/store so we can recover from a stacker error #19178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: chore_release-8.6.0
Choose a base branch
from

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Aug 8, 2025

Overview

We currently call manualRetrieve when skipping a stacker store labware step when recovering from an error. This is wrong and would cause the ER to be stuck in a loop forever.

This PR adds the manualStore command so we can actually skip the store step.

Fixes RQA-4514

@ahiuchingau ahiuchingau requested a review from a team as a code owner August 8, 2025 20:55
@ahiuchingau ahiuchingau requested review from ncdiehl11 and removed request for a team August 8, 2025 20:55
@ahiuchingau ahiuchingau changed the base branch from edge to chore_release-8.6.0 August 8, 2025 20:55
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.63%. Comparing base (3635cb6) to head (994a46e).
⚠️ Report is 1 commits behind head on chore_release-8.6.0.

Files with missing lines Patch % Lines
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts 0.00% 30 Missing ⚠️
...ganisms/ErrorRecoveryFlows/shared/SkipStepInfo.tsx 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.6.0   #19178      +/-   ##
=======================================================
- Coverage                24.01%   23.63%   -0.38%     
=======================================================
  Files                     3377     3377              
  Lines                   296971   297015      +44     
  Branches                 31523    31521       -2     
=======================================================
- Hits                     71304    70191    -1113     
- Misses                  225649   226806    +1157     
  Partials                    18       18              
Flag Coverage Δ
app 0.97% <0.00%> (-1.12%) ⬇️
protocol-designer 18.92% <0.00%> (-0.01%) ⬇️
step-generation 5.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ganisms/ErrorRecoveryFlows/shared/SkipStepInfo.tsx 0.00% <0.00%> (ø)
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts 0.00% <0.00%> (ø)

... and 89 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahiuchingau ahiuchingau force-pushed the fix_handle-recovering-from-stacker-store branch from 3708eff to ae3583c Compare August 8, 2025 21:12
@ahiuchingau ahiuchingau requested a review from a team as a code owner August 8, 2025 21:12
@ahiuchingau ahiuchingau force-pushed the fix_handle-recovering-from-stacker-store branch from ae3583c to d8904e8 Compare August 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant