feat: create component - top app bar #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentmaitre
changed the title
🟢 Netlify deploy for commit d2291f6 succeededDeploy preview: https://69402706cff36e0ac8c88618--ouds-android.netlify.app |
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
537972f to
09ab7f7
Compare
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
09ab7f7 to
159321b
Compare
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
159321b to
c42c88c
Compare
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
c42c88c to
0563c44
Compare
paulinea
requested changes
Dec 3, 2025
core/src/main/java/com/orange/ouds/core/component/OudsTopAppBar.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/OudsTopAppBar.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/OudsTopAppBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/orange/ouds/app/ui/components/topappbar/TopAppBarDemoScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/orange/ouds/app/ui/components/topappbar/TopAppBarDemoScreen.kt
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/OudsTopAppBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/orange/ouds/app/ui/tokens/TokenCategoryDetailScreen.kt
Show resolved
Hide resolved
This was referenced Dec 9, 2025
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
28dfa8a to
84595d1
Compare
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
84595d1 to
257f75f
Compare
florentmaitre
force-pushed
the
411-create-component---top-app-bar
branch
from
257f75f to
d2291f6
Compare
Member
|
Comme vu ensemble, la review est ok design. Je referai une passe complète avec le composant Figma et aussi avec la nouvelle issue pour intégrer la possibilité de choisir le nombre d'item à droite de la top app bar. |
# Conflicts: # NOTICE.txt # core/src/main/java/com/orange/ouds/core/component/OudsTag.kt # theme-contract/src/main/java/com/orange/ouds/theme/OudsDrawableResources.kt # theme-orange/src/main/java/com/orange/ouds/theme/orange/OrangeDrawableResources.kt # theme-sosh/src/main/java/com/orange/ouds/theme/sosh/SoshDrawableResources.kt # theme-wireframe/src/main/java/com/orange/ouds/theme/wireframe/WireframeDrawableResources.kt # Conflicts: # core/src/main/java/com/orange/ouds/core/component/OudsTag.kt
…t scale into account
… kind of navigation icons
…p app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
paulinea
force-pushed
the
411-create-component---top-app-bar
branch
from
d2291f6 to
a82800b
Compare
paulinea
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.