Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
OUDSToolBarTopandOUDSToolBarBottomSwiftUI components plusOUDSToolBarItemandOUDSToolBarNavigationItemhelpers for leading/trailing items and common icons (back,close,menu).ToolBarTopAppearanceModifierandToolBarBottomAppearanceModifierthat apply blur andbar.colorBgTranslucentfor iOS < 26 while deferring to system (Liquid Glass) behavior on iOS 26+.ToolBarItemStyleModifierto applycolors.contentDefaultand to applycolors.actionAccentas trailing background on iOS 26+, and introduceToolBarTitleViewto render title + optional subtitle using OUDS typography tokens.OUDS/Core/Components/Sources/_OUDSComponents.docc/Navigations.mdwith usage samples and notes about Liquid Glass and platform availability (iOS 15,macOS 15,visionOS 1, unavailable onwatchOS/tvOS).Testing
bundle exec fastlane formatbut it failed becausefastlaneis not available due tobundle installfailing with a403 Forbiddenfrom rubygems.org.bundle installbut it failed with a403 Forbiddenerror while fetching gems, so automatic format/build/test/lint pipelines were not executed.Codex Task