v8.1.1-rc.8 #4016
Merged
v8.1.1-rc.8 #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-tx Bump gas price on nonce issue
…ber-issue Remove unneeded toNumber
…update Fix setCompletedAndFinalizedRandomSamplingChallengeRecord parameters
…sk-query Add ASK timeout to blazgraph query
Mihajlo-Pavlovic
merged commit 2efc19b
into
v6/prerelease/testnet
7 of 10 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ); | ||
| } | ||
|
|
||
| console.timeEnd(`BatchGetCommand [NETWORK]: ${operationId} ${uals.length}`); |
There was a problem hiding this comment.
Bug: Debugging Code Leaks into Production
Extensive console.time() and console.timeEnd() calls, intended for temporary debugging and performance measurement, have been accidentally committed. These statements are present in BatchGetCommand, HandleBatchGetRequestCommand, and TripleStoreService methods (getAssertion, getAssertionsInBatch). They will pollute production logs with excessive timing information and should be removed.
Locations (3)
| result[ual] = results[index]; | ||
| } | ||
|
|
||
| endTimer(totalLabel); |
There was a problem hiding this comment.
Bug: Debugging Code in Production Methods
Unnecessary console.time and console.timeEnd calls for performance instrumentation were added to the getAssertion and getAssertionsInBatch methods. This debugging code should not be committed to production as it clutters console output.
Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.