-
Notifications
You must be signed in to change notification settings - Fork 86
v8.1.1-rc.8 #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v8.1.1-rc.8 #4016
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6e192b2
Bump gas price on nonce issue
Mihajlo-Pavlovic bbbd9c1
Fix setCompletedAndFinalizedRandomSamplingChallengeRecord parameters
Mihajlo-Pavlovic 132ba71
chore: add time logs to batch get protocol
Lexpeartha ed3c9aa
chore: integrate review feedback
Lexpeartha 482854e
remove unneeded toNumber
Mihajlo-Pavlovic e7786c3
Fix in another event
Mihajlo-Pavlovic 8ee55cd
chore: add even more logs to validate triple store
Lexpeartha c72f59d
chore: add missing parameter
Lexpeartha f801ddd
Add ASK timeout to blazgraph query
Mihajlo-Pavlovic cc5c854
Add default config
Mihajlo-Pavlovic d3becd3
Add ASK json handling
Mihajlo-Pavlovic fc87600
Add try catch in checkIfKnowledgeAssetExists
Mihajlo-Pavlovic 148c209
Merge pull request #4006 from OriginTrail/imrpovment/nonce-handling-f…
Mihajlo-Pavlovic aa3b108
Merge pull request #4010 from OriginTrail/fix/proofing-service-to-num…
Mihajlo-Pavlovic 5096587
Merge pull request #4008 from OriginTrail/fix/chalange-record-status-…
Mihajlo-Pavlovic f433541
Merge pull request #4012 from OriginTrail/improvment/add-timeout-to-a…
Mihajlo-Pavlovic 55605b6
version bump
Mihajlo-Pavlovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Debugging Code Leaks into Production
Extensive
console.time()andconsole.timeEnd()calls, intended for temporary debugging and performance measurement, have been accidentally committed. These statements are present inBatchGetCommand,HandleBatchGetRequestCommand, andTripleStoreServicemethods (getAssertion,getAssertionsInBatch). They will pollute production logs with excessive timing information and should be removed.Locations (3)
src/commands/protocols/get/receiver/v1.0.0/v1-0-0-handle-batch-get-request-command.js#L32-L103src/commands/protocols/get/sender/batch-get-command.js#L70-L411src/service/triple-store-service.js#L421-L590Fix in Cursor • Fix in Web