Changed sort method for private #263
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| // Group private triples by subject and flatten | ||
| const privateTriplesGrouped = kcTools.groupNquadsBySubject(dataset.private, true); | ||
| const privateTriplesGrouped = kcTools.groupNquadsBySubject(dataset.private, false).sort(); |
There was a problem hiding this comment.
Bug: Array Sorting Fails Without Comparator
The .sort() method called on an array of arrays without a comparator function will convert each array element to a string and sort based on string comparison, rather than comparing the arrays' contents properly. This produces unpredictable ordering for the grouped private triples. Either provide a custom comparator function or reconsider the sorting approach to match the intended behavior change described in the PR title "Changed sort method for private".
No description provided.