Skip to content

Changed sort method for private #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mihajlo-Pavlovic merged 1 commit into from
Oct 31, 2025
Merged

Changed sort method for private #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion managers/asset-operations-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export default class AssetOperationsManager {
dataset.private = kcTools.generateMissingIdsForBlankNodes(dataset.private);

// Group private triples by subject and flatten
const privateTriplesGrouped = kcTools.groupNquadsBySubject(dataset.private, true);
const privateTriplesGrouped = kcTools.groupNquadsBySubject(dataset.private, false).sort();
Copy link

@cursor cursor bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Array Sorting Fails Without Comparator

The .sort() method called on an array of arrays without a comparator function will convert each array element to a string and sort based on string comparison, rather than comparing the arrays' contents properly. This produces unpredictable ordering for the grouped private triples. Either provide a custom comparator function or reconsider the sorting approach to match the intended behavior change described in the PR title "Changed sort method for private".

Fix in Cursor Fix in Web

dataset.private = privateTriplesGrouped.flat();

// Compute private root and add to public
Expand Down