Skip to content

fix!: infinite recursion #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andredestro merged 1 commit into from
Apr 2, 2025
Merged

fix!: infinite recursion #18

andredestro merged 1 commit into from
Apr 2, 2025

Conversation

@andredestro
Copy link
Contributor

@andredestro andredestro commented Apr 2, 2025 •
edited
Loading

Description

Context

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality not to work as expected)

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows the code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@andredestro andredestro self-assigned this Apr 2, 2025
@andredestro andredestro force-pushed the fix/open-external-browser branch from 648b13c to a4e1504 Compare April 2, 2025 14:23
@andredestro andredestro marked this pull request as ready for review April 2, 2025 14:32
@andredestro andredestro requested a review from a team as a code owner April 2, 2025 14:32
@andredestro andredestro requested review from ItsChaceD, OS-martacarlos, OS-pedrogustavobilro and eric-horodyski and removed request for a team April 2, 2025 14:32
OS-pedrogustavobilro
OS-pedrogustavobilro reviewed Apr 2, 2025
View reviewed changes
@andredestro andredestro force-pushed the fix/open-external-browser branch from a4e1504 to c6b767c Compare April 2, 2025 14:55
@andredestro
Copy link
Contributor Author

andredestro commented Apr 2, 2025

I removed the OSIABApplicationRouterAdapterTests.swift because it was testing the UIApplication, that is a source code maintained by Apple.
If you disagree, let me know.

@andredestro andredestro force-pushed the fix/open-external-browser branch from c6b767c to 20aa316 Compare April 2, 2025 15:21
@OS-pedrogustavobilro OS-pedrogustavobilro changed the title fix: infinite recursion fix!: infinite recursion Apr 2, 2025
@andredestro andredestro merged commit b830b4a into development Apr 2, 2025
4 of 5 checks passed
@andredestro andredestro deleted the fix/open-external-browser branch April 2, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItsChaceD ItsChaceD ItsChaceD approved these changes

@OS-pedrogustavobilro OS-pedrogustavobilro OS-pedrogustavobilro approved these changes

@eric-horodyski eric-horodyski Awaiting requested review from eric-horodyski eric-horodyski is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

@OS-martacarlos OS-martacarlos Awaiting requested review from OS-martacarlos OS-martacarlos is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

Assignees

@andredestro andredestro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andredestro @ItsChaceD @OS-pedrogustavobilro