-
Notifications
You must be signed in to change notification settings - Fork 7
fix!: infinite recursion #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,9 @@ Pod::Spec.new do |spec| | |
| spec.author = { 'OutSystems Mobile Ecosystem' => '[email protected]' } | ||
|
|
||
| spec.source = { :http => "https://github.com/OutSystems/OSInAppBrowserLib-iOS/releases/download/#{spec.version}/OSInAppBrowserLib.zip", :type => "zip" } | ||
| spec.source_files = "OSInAppBrowserLib/**/*" | ||
| spec.vendored_frameworks = "OSInAppBrowserLib.xcframework" | ||
|
|
||
| spec.ios.deployment_target = '13.0' | ||
| spec.swift_versions = ['5.0', '5.1', '5.2', '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9'] | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 5 additions & 28 deletions
33
OSInAppBrowserLib/RouterAdapters/OSIABApplicationRouterAdapter.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,14 @@ | ||
| import UIKit | ||
|
|
||
| /// Protocol to be implemented by the objects that can handle opening URLs. | ||
| /// This is implemented by the `UIApplication` object that can be used as an External Browser. | ||
| public protocol OSIABApplicationDelegate: AnyObject { | ||
| func canOpenURL(_ url: URL) -> Bool | ||
| func open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey: Any], completionHandler completion: ((Bool) -> Void)?) | ||
| } | ||
|
|
||
| /// Provide a default implementations that abstracts the options parameter. | ||
| extension OSIABApplicationDelegate { | ||
| public func open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey: Any] = [:], completionHandler completion: ((Bool) -> Void)?) { | ||
| self.open(url, options: options, completionHandler: completion) | ||
| } | ||
| } | ||
|
|
||
| /// Make `UIApplication` conform to the `OSIABApplicationDelegate` protocol. | ||
| extension UIApplication: OSIABApplicationDelegate {} | ||
|
|
||
| /// Adapter that makes the required calls so that an `OSIABApplicationDelegate` implementation can perform the External Browser routing. | ||
| /// Adapter that makes the required calls so that can perform the External Browser routing. | ||
| public class OSIABApplicationRouterAdapter: OSIABRouter { | ||
| public typealias ReturnType = Bool | ||
|
|
||
| /// The object that will performing the URL opening. | ||
| private let application: OSIABApplicationDelegate | ||
|
|
||
|
|
||
| /// Constructor method. | ||
| /// - Parameter application: The object that will performing the URL opening. | ||
| public init(_ application: OSIABApplicationDelegate) { | ||
| self.application = application | ||
| } | ||
| public init() {} | ||
|
|
||
| public func handleOpen(_ url: URL, _ completionHandler: @escaping (ReturnType) -> Void) { | ||
| guard self.application.canOpenURL(url) else { return completionHandler(false) } | ||
| self.application.open(url, completionHandler: completionHandler) | ||
| guard UIApplication.shared.canOpenURL(url) else { return completionHandler(false) } | ||
| UIApplication.shared.open(url, completionHandler: completionHandler) | ||
| } | ||
| } |
20 changes: 0 additions & 20 deletions
20
OSInAppBrowserLibTests/Helper Files/OSApplicationStub.swift
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
OSInAppBrowserLibTests/OSIABApplicationRouterAdapterTests.swift
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.