ROU-12298: Updating comment for the types of Filtering supported #477
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates documentation comments to include additional Wijmo filter operators that were previously undocumented. The change is purely cosmetic and adds no functional modifications.
- Added documentation for 4 new filter operators: NBW, NEW, BLANK, and NOTBLANK
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * wijmo.grid.filter.Operator.NBW = 'NBW' | ||
| * wijmo.grid.filter.Operator.NC = 'NC' | ||
| * wijmo.grid.filter.Operator.NE = 'NE' | ||
| * wijmo.grid.filter.Operator.NEW = 'NEW' | ||
| * wijmo.grid.filter.Operator.BLANK = 'BLANK' | ||
| * wijmo.grid.filter.Operator.NOTBLANK = 'NOTBLANK' |
There was a problem hiding this comment.
The operators in the comment are not in alphabetical order. NBW appears at line 63, but NEW appears later at line 66. To maintain consistency with the rest of the list (which follows alphabetical ordering: BW, CT, EQ, EW, GE, GT, LE, LT, NBW, NC, NE), NEW should come before BLANK and NOTBLANK. Consider reordering to: NBW, NC, NE, NEW, BLANK, NOTBLANK (keeping in mind that BLANK and NOTBLANK may be intentionally at the end as special cases).
There was a problem hiding this comment.
@rugoncalves I believe we follow this rule in other places, so I think it's a good suggestion
This PR is for merely updating a comment. No impact.