Skip to content

ROU-12298: Updating comment for the types of Filtering supported #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rugoncalves wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ROU-12298: Updating comment for the types of Filtering supported #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Providers/DataGrid/Wijmo/Helper/FilterFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,12 @@ namespace Providers.DataGrid.Wijmo.Helper.FilterFactory {
* wijmo.grid.filter.Operator.GT = 'GT'
* wijmo.grid.filter.Operator.LE = 'LE'
* wijmo.grid.filter.Operator.LT = 'LT'
* wijmo.grid.filter.Operator.NBW = 'NBW'
* wijmo.grid.filter.Operator.NC = 'NC'
* wijmo.grid.filter.Operator.NE = 'NE'
* wijmo.grid.filter.Operator.NEW = 'NEW'
* wijmo.grid.filter.Operator.BLANK = 'BLANK'
* wijmo.grid.filter.Operator.NOTBLANK = 'NOTBLANK'
Comment on lines +63 to +68
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operators in the comment are not in alphabetical order. NBW appears at line 63, but NEW appears later at line 66. To maintain consistency with the rest of the list (which follows alphabetical ordering: BW, CT, EQ, EW, GE, GT, LE, LT, NBW, NC, NE), NEW should come before BLANK and NOTBLANK. Consider reordering to: NBW, NC, NE, NEW, BLANK, NOTBLANK (keeping in mind that BLANK and NOTBLANK may be intentionally at the end as special cases).

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@gnbm gnbm Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rugoncalves I believe we follow this rule in other places, so I think it's a good suggestion

* @param {wijmo.grid.filter.Operator} operator
* @returns {*} {string}
*/
Expand Down