Darwin: Implement Mach exception ports instead of signals #12280
+197
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
changed the title
F0bes
force-pushed
the
mach-exceptions
branch
from
b139c99 to
b39dfce
Compare
Contributor
|
R&C2 Megaturret uses self modifying code, tested (in this case the Mega Megaturret specifically but they should be identical on the SMC front) and works with this PR on macOS 15 with Apple Silicon |
F0bes
force-pushed
the
mach-exceptions
branch
2 times, most recently
from
bd2970e to
befcca8
Compare
DigitalMajestic
approved these changes
Nov 20, 2025
Contributor
DigitalMajestic
left a comment
DigitalMajestic
left a comment
There was a problem hiding this comment.
Still working good.
F0bes
commented
Nov 21, 2025
common/Darwin/DarwinMisc.cpp
Outdated
| } | ||
|
|
||
| mach_port_t previous; | ||
| mach_port_request_notification(mach_task_self(), port, MACH_NOTIFY_NO_SENDERS, 0, port, MACH_MSG_TYPE_MAKE_SEND_ONCE, &previous); |
Member
Author
There was a problem hiding this comment.
I need to check the result of this call, and also mach_port_deallocate previous if it is not MACH_PORT_NULL
Credit goes to the Julia language and Dolphin emulator for their free and open source implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to the Julia language and Dolphin emulator for their free and open source implementations
Description of Changes
Instead of relying on signal handling for our segfault handler, create mach exception ports.
Rationale behind Changes
I was hoping this would allow me to reliably use lldb but it appears that rosetta might still be a blocker.
Suggested Testing Steps
Test games with self modifying code?