Qt: Adds time and date + group OSD checkboxes#12642
Qt: Adds time and date + group OSD checkboxes#12642RedDevilus wants to merge 3 commits intoPCSX2:masterfrom
Conversation
|
I'm usually opposed to changing the OSD settings, but I like headers for categories of settings. Right now, if the user doesn't just check all the boxes (maybe we should have one for 'enable all'?), they have to scan through every option until they find the one(s) they want. Likewise, system date and time are clearly relevant information for TAS and plausibly relevant for real-time players. I could probably bikeshed about the exact layout of the settings, but I think both the two new settings and the inclusion of headers are positive steps. Bikeshedding: I wonder if there's a better name for "Show Statistics" and "Show Indicators", but I can't say for sure; maybe they're too broad to have a good, precise name, and that isn't this PR's problem anyway. I also think 'Warnings' is better than 'Warnings for user'. |
Yeah, I wanted to add a global toggle for the OSD checkboxes, maybe even per column (3) but I didn't want to blast with feature creep and going with massive changes. Just wanted to test some waters and then adjust some more in the future like having no dropshadows on the text annoys me that I can barely see stuff, maybe even make it so transparency can be adjusted or even the colors but that's just some ideas I might want to incorporate. For the renaming not sure what's best, also need to keep in mind not breaking translations for a bit better (if it even succeeds) English descriptors of items. |
|
I think having the date and time is a silly addition. |
|
I don't this is really needed , since the time is already mentioned in the FSUi |
|
Nobody is going to press Escape constantly to check the time or alt tab if it's fullscreen. Never said it was essential ,but I personally think it has a place and if you don't need it you can also not enable it. |
|
i have a feeling the OSD is becoming more bloated with this , if someone really needs the time they can run RTSS or similar tools |
RedDevilus
force-pushed
the
MinorQtWork21
branch
2 times, most recently
from
ddef280 to
29dc396
Compare
JordanTheToaster
left a comment
JordanTheToaster
left a comment
There was a problem hiding this comment.
I can now see the time and date while being overstimulated by OSD information.
|
Now i can keep track of time while playing.
|
Adds the options system time and system date in the OSD section of Qt and also FSUI for Big Picture mode. Done some preliminary work on grouping all the OSD checkboxes including the new ones in a better to glance 3 column viewscreen.
…ation Currently typo fixed and instead of Time and Date being on seperate lines and then speedline, use a pipe for divider for same line. Also got rid of Time: and Date: being displayed it is kinda redudant.
| tr("Shows the current system hardware information on the OSD.")); | ||
|
|
||
| dialog->registerWidgetHelp(m_ui.osdShowSystemTime, tr("Show System Time"), tr("Unchecked"), | ||
| tr("Shows the current system time in the top-right corner of the display currently with Hour:Minute:Second (HH:MM:SS) format.")); |
There was a problem hiding this comment.
Should be "Shows the current system time in Hour:Minute:Second (HH:MM:SS) format." Top-right is no longer static, and "current" is repeated ("current system time" and "display currently") Same with the next two dialogs. This static "top-right" needs to be fixed elsewhere too.
There was a problem hiding this comment.
Yeah, think that was before the initial creation of the PR, but it's going to get feature crept and don't want to break stuff adding the stuff.
|
Pretty annoying it's nagging about unnecessary stuff: D:\a\pcsx2\pcsx2\pcsx2\ImGui\FullscreenUI.cpp(42,1): error C1083: Cannot open include file: 'IconsFontAwesome5.h': No such file or directory [D:\a\pcsx2\pcsx2\pcsx2\pcsx2.vcxproj] D:\a\pcsx2\pcsx2\pcsx2\ImGui\ImGuiOverlays.cpp(1007,82): warning C4996: 'fmt::v11::localtime': was declared deprecated [D:\a\pcsx2\pcsx2\pcsx2\pcsx2.vcxproj] D:\a\pcsx2\pcsx2\pcsx2\ImGui\ImGuiOverlays.cpp(1207,76): warning C4996: 'fmt::v11::localtime': was declared deprecated [D:\a\pcsx2\pcsx2\pcsx2\pcsx2.vcxproj] Actions it's not broken my man. |
|
It looks like if you do system time and PCSX2 version simultaneously, the PCSX2 version gets bumped down a line and gets a separator pipe, but it shouldn't have one. Third screenshot shows what it should look like (no separator pipe because the PCSX2 version is the only item on its line). |
Looks like you didn't rebase correctly here |
|
It looks like the PR only fetches system time but does not account for the possibility the user is using an RTC other than the default system time one. |
Not sure if it should follow RTC perse as it doesn't follow the PS2 internal clock and date (desync if you press Tab or Press F4). This PR syncs up with system time and yes on boot in BIOS in PCSX2 it syncs up everything once. Maybe a better method exists in future PR where we can have PS2 System Clock vs PC System Clock being obvious. |
|
I disagreed with fobes' comment initially because I thought this was for the RTC time and date, not the desktop time and date. Even though the PR works well for what it intends to do and needs just a few tweaks functionality-wise, that information is trivial for a user to access outside of PCSX2 and unfortunately feels very "I want PCSX2 to file my taxes". |
Done some preliminary work on grouping all the OSD checkboxes including the new ones in a better to glance 3 column viewscreen. Split from PCSX2#12642 which had system time and date on top
Done some preliminary work on grouping all the OSD checkboxes including the new ones in a better to glance 3 column viewscreen. Split from #12642 which had system time and date on top
7 participants
Description of Changes
Adds the options system time and system date in the OSD section of Qt and also FSUI for Big Picture mode.
Done some preliminary work on grouping all the OSD checkboxes including the new ones in a better to glance 3 column viewscreen. Also keep in mind I enabled all the OSD options as an example, no regular user will do that hence it will feel a bit cluttered at a glance with these below screenshots. V1 is the one in the code but I can change it later in future if need be.
Master:
PR:
V1 Chosen Minimal:
V2 Minimal:
V3 Mix letters and numbers:
V4 V2 basically with format in parentheses:
Rationale behind Changes
While there is already date on the gamelist and clock in the FSUI, I find it lacks control whilst in-game. Be it for easy recording, sharing screen or maybe even speedrunning. In future it can also be tracked per locale because countries can have a mix of / or - or even dots to others to a different sorting of day, month and year. In future I can also add clock and calendar icons.
I want it more like RTSS or other overlays where you can get stuff like this:
And you won't enable every option on there either.
Current version can be adjusted also like this:
I want to do dropshadows on the text in future as well, if there is white-ish background you can barely see that as well, so it's also a smaller PR for another future PR.
Suggested Testing Steps
Test in Big Picture Mode, global and per-game settings on multiple OSes.