Deps: Specify prefix path for Qt build#12888
Draft
TheLastRar wants to merge 1 commit intoPCSX2:masterfrom
Draft
Conversation
Member
|
Might want to use a list of common arguments like the macOS build pcsx2/.github/workflows/scripts/macos/build-dependencies.sh Lines 50 to 57 in 33ab6fd |
38c21ac to
a4a9953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Specify
-DCMAKE_PREFIX_PATHwhen building Qt on LinuxRationale behind Changes
Local installs of Qt could break the build
Other platforms specify this already
Suggested Testing Steps
Install an older version of Qt on the system (like 6.8)
Run the deps script and see if the build completes
Did you use AI to help find, test, or implement this issue or feature?
No